From: Maximilian Luz <luzmaximilian@gmail.com>
To: Jarrett Schultz <jaschultzms@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>
Cc: linux-arm-msm@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Felipe Balbi <balbi@kernel.org>,
Jarrett Schultz <jaschultz@microsoft.com>
Subject: Re: [PATCH v2 2/5] platform: surface: Propagate ACPI Dependency
Date: Mon, 8 Nov 2021 18:58:34 +0100 [thread overview]
Message-ID: <6e6e478b-eb12-5d7b-e944-4e6c02e46d4c@gmail.com> (raw)
In-Reply-To: <20211108164449.3036210-3-jaschultz@microsoft.com>
On 11/8/21 17:44, Jarrett Schultz wrote:> From: Jarrett Schultz <jaschultzMS@gmail.com>
>
> Since the Surface XBL Driver does not depend on ACPI, the
> platform/surface directory as a whole no longer depends on ACPI. With
> respect to this, the ACPI dependency is moved into each config that
> depends on ACPI individually.
>
> Signed-off-by: Jarrett Schultz <jaschultz@microsoft.com>
Some remarks inline:
> ---
>
> Changes in v2:
> - Created to propagate ACPI dependency
>
> ---
>
> drivers/platform/surface/Kconfig | 12 +++++++++++-
You also need to account for included Kconfigs, specifically:
drivers/platform/surface/aggregator/Kconfig.
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/surface/Kconfig b/drivers/platform/surface/Kconfig
> index 3105f651614f..0d3970e1d144 100644
> --- a/drivers/platform/surface/Kconfig
> +++ b/drivers/platform/surface/Kconfig
> @@ -5,7 +5,6 @@
>
> menuconfig SURFACE_PLATFORMS
> bool "Microsoft Surface Platform-Specific Device Drivers"
> - depends on ACPI
> default y
> help
> Say Y here to get to see options for platform-specific device drivers
> @@ -18,6 +17,7 @@ if SURFACE_PLATFORMS
>
> config SURFACE3_WMI
> tristate "Surface 3 WMI Driver"
> + depends on ACPI
This is redundant, you can drop that. ACPI_WMI already depends on ACPI.
> depends on ACPI_WMI
> depends on DMI
> depends on INPUT
> @@ -30,12 +30,14 @@ config SURFACE3_WMI
>
> config SURFACE_3_BUTTON
> tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet"
> + depends on ACPI
> depends on KEYBOARD_GPIO && I2C
> help
> This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet.
>
> config SURFACE_3_POWER_OPREGION
> tristate "Surface 3 battery platform operation region support"
> + depends on ACPI
> depends on I2C
> help
> This driver provides support for ACPI operation
> @@ -43,6 +45,7 @@ config SURFACE_3_POWER_OPREGION
>
> config SURFACE_ACPI_NOTIFY
> tristate "Surface ACPI Notify Driver"
> + depends on ACPI
As mentioned above, you're missing aggregator/Kconfig. All you need to
do is add "depends on ACPI" to SURFACE_AGGREGATOR in that file. Then you
can drop the "depends on ACPI" for anything that depends on that.
Same holds for the couple of options depending on SURFACE_AGGREGATOR
below.
> depends on SURFACE_AGGREGATOR
> help
> Surface ACPI Notify (SAN) driver for Microsoft Surface devices.
> @@ -62,6 +65,7 @@ config SURFACE_ACPI_NOTIFY
>
> config SURFACE_AGGREGATOR_CDEV
> tristate "Surface System Aggregator Module User-Space Interface"
> + depends on ACPI
> depends on SURFACE_AGGREGATOR
> help
> Provides a misc-device interface to the Surface System Aggregator
> @@ -79,6 +83,7 @@ config SURFACE_AGGREGATOR_CDEV
>
> config SURFACE_AGGREGATOR_REGISTRY
> tristate "Surface System Aggregator Module Device Registry"
> + depends on ACPI
> depends on SURFACE_AGGREGATOR
> depends on SURFACE_AGGREGATOR_BUS
> help
> @@ -106,6 +111,7 @@ config SURFACE_AGGREGATOR_REGISTRY
>
> config SURFACE_DTX
> tristate "Surface DTX (Detachment System) Driver"
> + depends on ACPI
> depends on SURFACE_AGGREGATOR
> depends on INPUT
> help
> @@ -126,6 +132,7 @@ config SURFACE_DTX
>
> config SURFACE_GPE
> tristate "Surface GPE/Lid Support Driver"
> + depends on ACPI
> depends on DMI
> help
> This driver marks the GPEs related to the ACPI lid device found on
> @@ -135,6 +142,7 @@ config SURFACE_GPE
>
> config SURFACE_HOTPLUG
> tristate "Surface Hot-Plug Driver"
> + depends on ACPI
> depends on GPIOLIB
> help
> Driver for out-of-band hot-plug event signaling on Microsoft Surface
> @@ -154,6 +162,7 @@ config SURFACE_HOTPLUG
>
> config SURFACE_PLATFORM_PROFILE
> tristate "Surface Platform Profile Driver"
> + depends on ACPI
> depends on SURFACE_AGGREGATOR_REGISTRY
> select ACPI_PLATFORM_PROFILE
> help
> @@ -176,6 +185,7 @@ config SURFACE_PLATFORM_PROFILE
>
> config SURFACE_PRO3_BUTTON
> tristate "Power/home/volume buttons driver for Microsoft Surface Pro 3/4 tablet"
> + depends on ACPI
> depends on INPUT
> help
> This driver handles the power/home/volume buttons on the Microsoft Surface Pro 3/4 tablet.
>
next prev parent reply other threads:[~2021-11-08 17:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 16:44 [PATCH v2 0/5] platform: surface: Introduce Surface XBL Driver Jarrett Schultz
2021-11-08 16:44 ` [PATCH v2 1/5] dt-bindings: platform: microsoft: Document surface xbl Jarrett Schultz
2021-11-08 18:48 ` Bjorn Andersson
2021-11-09 4:06 ` Rob Herring
2021-11-12 14:39 ` Rob Herring
2021-11-16 16:17 ` Jarrett Schultz
2021-11-08 16:44 ` [PATCH v2 2/5] platform: surface: Propagate ACPI Dependency Jarrett Schultz
2021-11-08 17:58 ` Maximilian Luz [this message]
2021-11-11 19:45 ` kernel test robot
2021-11-08 16:44 ` [PATCH v2 3/5] platform: surface: Add surface xbl Jarrett Schultz
2021-11-08 18:39 ` Bjorn Andersson
2021-11-16 22:05 ` Jarrett Schultz
2021-11-08 16:44 ` [PATCH v2 4/5] arm64: dts: qcom: sm8150: Add imem section Jarrett Schultz
2021-11-08 18:41 ` Bjorn Andersson
2021-11-08 16:44 ` [PATCH v2 5/5] arm64: dts: qcom: surface-duo: Add surface xbl Jarrett Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e6e478b-eb12-5d7b-e944-4e6c02e46d4c@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jaschultz@microsoft.com \
--cc=jaschultzms@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).