From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Akinobu Mita <akinobu.mita@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger
Date: Sun, 1 Sep 2019 18:53:34 +0200 [thread overview]
Message-ID: <6ebeedab-4a7f-14ea-d62e-9184e911047f@gmail.com> (raw)
In-Reply-To: <1567090164-6819-1-git-send-email-akinobu.mita@gmail.com>
Hi Akinobu,
Thank you for the patch.
I have one nit below but in general it looks good to me.
I've tested it with 2000 mtd triggers (~14kB file size)
and it worked flawlessly.
Still, I would like to have ack from Greg for it.
Adding Greg on Cc.
On 8/29/19 4:49 PM, Akinobu Mita wrote:
> Reading /sys/class/leds/<led>/trigger returns all available LED triggers.
> However, the size of this file is limited to PAGE_SIZE because of the
> limitation for sysfs attribute.
>
> Enabling LED CPU trigger on systems with thousands of CPUs easily hits
> PAGE_SIZE limit, and makes it impossible to see all available LED triggers
> and which trigger is currently activated.
>
> This converts /sys/class/leds/<led>/trigger to bin attribute and removes
> the PAGE_SIZE limitation.
>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
> drivers/leds/led-class.c | 8 ++---
> drivers/leds/led-triggers.c | 84 ++++++++++++++++++++++++++++++++++-----------
> drivers/leds/leds.h | 6 ++++
> include/linux/leds.h | 5 ---
> 4 files changed, 74 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 4793e77..8b5a1d1 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -73,13 +73,13 @@ static ssize_t max_brightness_show(struct device *dev,
> static DEVICE_ATTR_RO(max_brightness);
>
> #ifdef CONFIG_LEDS_TRIGGERS
> -static DEVICE_ATTR(trigger, 0644, led_trigger_show, led_trigger_store);
> -static struct attribute *led_trigger_attrs[] = {
> - &dev_attr_trigger.attr,
> +static BIN_ATTR(trigger, 0644, led_trigger_read, led_trigger_write, 0);
> +static struct bin_attribute *led_trigger_bin_attrs[] = {
> + &bin_attr_trigger,
> NULL,
> };
> static const struct attribute_group led_trigger_group = {
> - .attrs = led_trigger_attrs,
> + .bin_attrs = led_trigger_bin_attrs,
> };
> #endif
>
> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
> index 8d11a5e..4788e00 100644
> --- a/drivers/leds/led-triggers.c
> +++ b/drivers/leds/led-triggers.c
> @@ -16,6 +16,7 @@
> #include <linux/rwsem.h>
> #include <linux/leds.h>
> #include <linux/slab.h>
> +#include <linux/mm.h>
> #include "leds.h"
>
> /*
> @@ -26,9 +27,11 @@ LIST_HEAD(trigger_list);
>
> /* Used by LED Class */
>
> -ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
> - const char *buf, size_t count)
> +ssize_t led_trigger_write(struct file *filp, struct kobject *kobj,
> + struct bin_attribute *bin_attr, char *buf,
> + loff_t pos, size_t count)
> {
> + struct device *dev = kobj_to_dev(kobj);
> struct led_classdev *led_cdev = dev_get_drvdata(dev);
> struct led_trigger *trig;
> int ret = count;
> @@ -64,39 +67,80 @@ ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
> mutex_unlock(&led_cdev->led_access);
> return ret;
> }
> -EXPORT_SYMBOL_GPL(led_trigger_store);
> +EXPORT_SYMBOL_GPL(led_trigger_write);
>
> -ssize_t led_trigger_show(struct device *dev, struct device_attribute *attr,
> - char *buf)
> +__printf(4, 5)
> +static int led_trigger_snprintf(char *buf, size_t size, bool query,
> + const char *fmt, ...)
> +{
> + va_list args;
> + int i;
> +
> + va_start(args, fmt);
> + if (query)
> + i = vsnprintf(NULL, 0, fmt, args);
> + else
> + i = vscnprintf(buf, size, fmt, args);
> + va_end(args);
> +
> + return i;
> +}
> +
> +static int led_trigger_format(char *buf, size_t size, bool query,
> + struct led_classdev *led_cdev)
> {
> - struct led_classdev *led_cdev = dev_get_drvdata(dev);
> struct led_trigger *trig;
> int len = 0;
>
> + len += led_trigger_snprintf(buf + len, size - len, query, "%s",
Here we know len is 0 so we can pass just buf and size.
> + led_cdev->trigger ? "none" : "[none]");
> +
> + list_for_each_entry(trig, &trigger_list, next_trig) {
> + bool hit = led_cdev->trigger &&
> + !strcmp(led_cdev->trigger->name, trig->name);
> +
> + len += led_trigger_snprintf(buf + len, size - len, query,
> + " %s%s%s", hit ? "[" : "",
> + trig->name, hit ? "]" : "");
> + }
> +
> + len += led_trigger_snprintf(buf + len, size - len, query, "\n");
> +
> + return len;
> +}
> +
> +ssize_t led_trigger_read(struct file *filp, struct kobject *kobj,
> + struct bin_attribute *attr, char *buf,
> + loff_t pos, size_t count)
> +{
> + struct device *dev = kobj_to_dev(kobj);
> + struct led_classdev *led_cdev = dev_get_drvdata(dev);
> + void *data;
> + int len;
> +
> down_read(&triggers_list_lock);
> down_read(&led_cdev->trigger_lock);
>
> - if (!led_cdev->trigger)
> - len += scnprintf(buf+len, PAGE_SIZE - len, "[none] ");
> + len = led_trigger_format(NULL, 0, true, led_cdev);
> + data = kvmalloc(len + 1, GFP_KERNEL);
> + if (data)
> + len = led_trigger_format(data, len + 1, false, led_cdev);
> else
> - len += scnprintf(buf+len, PAGE_SIZE - len, "none ");
> + len = -ENOMEM;
>
> - list_for_each_entry(trig, &trigger_list, next_trig) {
> - if (led_cdev->trigger && !strcmp(led_cdev->trigger->name,
> - trig->name))
> - len += scnprintf(buf+len, PAGE_SIZE - len, "[%s] ",
> - trig->name);
> - else
> - len += scnprintf(buf+len, PAGE_SIZE - len, "%s ",
> - trig->name);
> - }
> up_read(&led_cdev->trigger_lock);
> up_read(&triggers_list_lock);
>
> - len += scnprintf(len+buf, PAGE_SIZE - len, "\n");
> + if (len < 0)
> + return len;
> +
> + len = memory_read_from_buffer(buf, count, &pos, data, len);
> +
> + kvfree(data);
> +
> return len;
> }
> -EXPORT_SYMBOL_GPL(led_trigger_show);
> +EXPORT_SYMBOL_GPL(led_trigger_read);
>
> /* Caller must ensure led_cdev->trigger_lock held */
> int led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
> diff --git a/drivers/leds/leds.h b/drivers/leds/leds.h
> index 47b2294..a0ee33c 100644
> --- a/drivers/leds/leds.h
> +++ b/drivers/leds/leds.h
> @@ -23,6 +23,12 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev,
> enum led_brightness value);
> void led_set_brightness_nosleep(struct led_classdev *led_cdev,
> enum led_brightness value);
> +ssize_t led_trigger_read(struct file *filp, struct kobject *kobj,
> + struct bin_attribute *attr, char *buf,
> + loff_t pos, size_t count);
> +ssize_t led_trigger_write(struct file *filp, struct kobject *kobj,
> + struct bin_attribute *bin_attr, char *buf,
> + loff_t pos, size_t count);
>
> extern struct rw_semaphore leds_list_lock;
> extern struct list_head leds_list;
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index fd2eb7c..33ae825 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -290,11 +290,6 @@ struct led_trigger {
> #define led_trigger_get_led(dev) ((struct led_classdev *)dev_get_drvdata((dev)))
> #define led_trigger_get_drvdata(dev) (led_get_trigger_data(led_trigger_get_led(dev)))
>
> -ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
> - const char *buf, size_t count);
> -ssize_t led_trigger_show(struct device *dev, struct device_attribute *attr,
> - char *buf);
> -
> /* Registration functions for complex triggers */
> extern int led_trigger_register(struct led_trigger *trigger);
> extern void led_trigger_unregister(struct led_trigger *trigger);
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-09-01 16:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:49 [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger Akinobu Mita
2019-09-01 16:53 ` Jacek Anaszewski [this message]
2019-09-02 18:12 ` Greg KH
2019-09-02 18:47 ` Jacek Anaszewski
2019-09-02 19:08 ` Greg KH
2019-09-03 13:55 ` Akinobu Mita
2019-09-03 14:07 ` Greg KH
2019-09-03 14:21 ` Akinobu Mita
2019-09-03 14:44 ` Greg KH
2019-09-03 18:18 ` Jacek Anaszewski
2019-09-03 18:32 ` Greg KH
2019-09-03 20:30 ` Pavel Machek
2019-09-01 17:23 ` Pavel Machek
2019-09-12 14:39 [PATCH] leds: fix /sys/class/leds/<led>/trigger Akinobu Mita
2019-09-12 14:39 ` [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger Akinobu Mita
2019-09-12 17:15 ` Jacek Anaszewski
2019-09-13 0:34 ` Akinobu Mita
2019-09-13 5:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ebeedab-4a7f-14ea-d62e-9184e911047f@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).