From: Alexandre Torgue <alexandre.torgue@st.com>
To: Yannick Fertre <yannick.fertre@st.com>,
Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Benjamin Gaignard <benjamin.gaignard@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: <linux-watchdog@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Philippe Cornu <philippe.cornu@st.com>,
Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 3/5] ARM: dts: stm32ap: Add watchdog support for STM32F429 SoC
Date: Wed, 22 Mar 2017 14:50:20 +0100 [thread overview]
Message-ID: <70b47d08-9628-f0c6-094f-c3712527bda8@st.com> (raw)
In-Reply-To: <1490189786-19232-4-git-send-email-yannick.fertre@st.com>
Hi
On 03/22/2017 02:36 PM, Yannick Fertre wrote:
> Signed-off-by: Yannick FERTRE <yannick.fertre@st.com>
> ---
Please add a commit message, and change commit header as following:
ARM: dts: stm32: ...
> arch/arm/boot/dts/stm32f429.dtsi | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index ee0da97..148273b 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -65,7 +65,7 @@
> clock-frequency = <32768>;
> };
>
> - clk-lsi {
> + clk_lsi: clk-lsi {
> #clock-cells = <0>;
> compatible = "fixed-clock";
> clock-frequency = <32000>;
> @@ -812,6 +812,13 @@
> clocks = <&rcc 0 STM32F4_AHB2_CLOCK(RNG)>;
>
> };
> +
> + iwdg: iwdg@40003000 {
Please try to keep nodes ordered.
> + compatible = "st,stm32-iwdg";
> + reg = <0x40003000 0x400>;
> + clocks = <&clk_lsi>;
> + status = "disabled";
> + };
> };
> };
>
>
next prev parent reply other threads:[~2017-03-22 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 13:36 [PATCH v1 0/5] STM32 Independant watchdog Yannick Fertre
2017-03-22 13:36 ` [PATCH v1 1/5] dt-bindings: Document STM32 IWDG bindings Yannick Fertre
2017-03-22 13:36 ` [PATCH v1 2/5] drivers: watchdog: Add STM32 IWDG driver Yannick Fertre
2017-03-22 13:36 ` [PATCH v1 3/5] ARM: dts: stm32ap: Add watchdog support for STM32F429 SoC Yannick Fertre
2017-03-22 13:50 ` Alexandre Torgue [this message]
2017-03-22 13:36 ` [PATCH v1 4/5] ARM: dts: stm32ap: Add watchdog support for STM32F429 eval board Yannick Fertre
2017-03-22 13:51 ` Alexandre Torgue
2017-03-22 13:36 ` [PATCH v1 5/5] ARM: configs: Add watchdog support in STM32 defconfig Yannick Fertre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70b47d08-9628-f0c6-094f-c3712527bda8@st.com \
--to=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gabriel.fernandez@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mcoquelin.stm32@gmail.com \
--cc=philippe.cornu@st.com \
--cc=robh+dt@kernel.org \
--cc=wim@iguana.be \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).