From: John Garry <john.garry@huawei.com>
To: Andi Kleen <ak@linux.intel.com>, "liuqi (BA)" <liuqi115@hisilicon.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Jin Yao <yao.jin@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Zhangshaokun <zhangshaokun@hisilicon.com>,
huangdaode <huangdaode@hisilicon.com>,
linyunsheng <linyunsheng@huawei.com>
Subject: Re: [QUESTION]perf stat: comment of miss ratio
Date: Wed, 13 Nov 2019 10:45:54 +0000 [thread overview]
Message-ID: <71f30f49-d8b4-abff-9f75-674dcbb7fad0@huawei.com> (raw)
In-Reply-To: <20191109024754.GA573472@tassilo.jf.intel.com>
On 09/11/2019 02:47, Andi Kleen wrote:
>> Relevant code is checked to make sure that the ratio is calculated by
>>
>> L1-dcache-load-misses/L1-dcache-loads, data "7.58%=30249/399189*100%" also
>>
>> proves this conclusion.
>>
>> So, I'm not sure why we use "of all L1-dcache hits" here to describe miss
>> ratio,
>
> Yes you're right it should be "of all L1-dcache accesses"
>
> Please send a patch to fix the string and also check if this isn't wrong with some other
> ratio too.
>
" 399,189 L1-dcache-loads # 246.396 M/sec
30,249 L1-dcache-load-misses # 7.58% of all L1-dcache
hits (18.04%)"
If accesses and loads are equivalent, could we use consistent terminology?
Thanks,
John
prev parent reply other threads:[~2019-11-13 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F57F094935A66448B135517D3F6EA397F35063@DGGEMA504-MBS.china.huawei.com>
2019-11-09 2:47 ` [QUESTION]perf stat: comment of miss ratio Andi Kleen
2019-11-09 3:19 ` Qi Liu
2019-11-09 18:46 ` Andi Kleen
2019-11-13 10:45 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71f30f49-d8b4-abff-9f75-674dcbb7fad0@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=huangdaode@hisilicon.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=liuqi115@hisilicon.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).