From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D0FC4338F for ; Thu, 29 Jul 2021 16:55:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7FBF60560 for ; Thu, 29 Jul 2021 16:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229935AbhG2Qzh (ORCPT ); Thu, 29 Jul 2021 12:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbhG2Qzg (ORCPT ); Thu, 29 Jul 2021 12:55:36 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 219A2C061765 for ; Thu, 29 Jul 2021 09:55:33 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id 48-20020a9d0bb30000b02904cd671b911bso6542377oth.1 for ; Thu, 29 Jul 2021 09:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hgC1Q4pMoeXbvHStOPFFYkLCsk1OZWIPRrIaBVnONRI=; b=XutRjkdHw48vdg5XN70l1ypLeUDJqRnm6H13Jem2+Z5AyMWS5W1/Kv/k09zcJ/bnoq rk2HiyxskeP2QVNOPd1m0g1cKw0HDDaAonISyZe16aVWOcInCaFkH4E4WYxiUjpysyq5 id5VXhW99jjQiFBB73BwvEu7tFCta27R+cUZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hgC1Q4pMoeXbvHStOPFFYkLCsk1OZWIPRrIaBVnONRI=; b=bHS1bwsQRL/rD+Vol5YIxPjf6pZ5p2KJF6h/dUxL+quI+i0F5BzTbjHI/exXL62fQy rMPENeQvo150AQjbEaz8FwqHoHZ/7eepoLJT/iWF3zN+sUbjNd79kPjVZb9oG9Uo2vkT Y4QxzWj/2dL33mp5jEbRn3tULmP3GcTNCQGLx1ieJUM4CZgb8vSTtL1YHaDIezL7q3f3 3m7Glt8MupvnKfFHgQZYZk2RrrHExnEnmWsxxpEAnubTau+3u4I1H1GpHUTfWuJTiMzA cgS/sCv/LQO5Awhnv3p/7S2eH6d9Pw3d8jV8bw+V7qfSz1lF2A6yHn/nUYHwGjflTWw/ MZqQ== X-Gm-Message-State: AOAM532Xeq3TB+LOPLebYee9hqr0GV0EiE7+z0lsuiLFwsH2E71iOpI8 MqBQidMCyMTL92BeNc8pzVMbEw== X-Google-Smtp-Source: ABdhPJwjwbXtqv/YaHyHQl731cs7U5y/NpGcnFr/liM5DMdeNIrOW+KQplyhTo++fjEjlu+8Ac2gTQ== X-Received: by 2002:a05:6830:2b23:: with SMTP id l35mr4160041otv.21.1627577732507; Thu, 29 Jul 2021 09:55:32 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id s24sm549018ooq.37.2021.07.29.09.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 09:55:32 -0700 (PDT) Subject: Re: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup To: Bart Van Assche , Greg KH Cc: Christoph Hellwig , Joel Becker , linux-kernel@vger.kernel.org, Brendan Higgins , David Gow , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Bodo Stroesser , "Martin K . Petersen" , Yanko Kaneti , Shuah Khan References: <20210729044125.7435-1-bvanassche@acm.org> <20210729044125.7435-3-bvanassche@acm.org> <8ab0ea44-760a-61df-0b9a-8b314ca9a0fe@acm.org> From: Shuah Khan Message-ID: <733cb812-8696-45f4-356d-cfe5bd85eb9b@linuxfoundation.org> Date: Thu, 29 Jul 2021 10:55:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8ab0ea44-760a-61df-0b9a-8b314ca9a0fe@acm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/21 10:52 AM, Bart Van Assche wrote: > On 7/28/21 10:55 PM, Greg KH wrote: >> On Wed, Jul 28, 2021 at 09:41:24PM -0700, Bart Van Assche wrote: >>> Reviewed-by: Brendan Higgins >>> Cc: David Gow >>> Cc: Shuah Khan >>> Cc: kunit-dev@googlegroups.com >>> Cc: linux-kselftest@vger.kernel.org >>> Cc: Bodo Stroesser >>> Cc: Martin K. Petersen >>> Cc: Yanko Kaneti >>> Signed-off-by: Bart Van Assche >>> --- >> >> I know I do not take patches without any changelog text.  Maybe other >> maintainers are more lax :( > > Almost every patch from me has an elaborate changelog. For this patch I chose not to add a changelog since I think that the subject is self-explanatory? > I don't take patches without change logs either. I can't say the subject tells me what you are doing. Please add a change log. thanks, -- Shuah