From: Oliver Hartkopp <socketcan@hartkopp.net>
To: kernel test robot <rong.a.chen@intel.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
lkp@01.org, ltp@lists.linux.it
Subject: Re: [can] 60649d4e0a: ltp.can_rcv_own_msgs.fail
Date: Mon, 29 Jul 2019 16:13:15 +0200 [thread overview]
Message-ID: <786568d6-bd24-327a-8367-319efbe2cccb@hartkopp.net> (raw)
In-Reply-To: <20190729094112.GM22106@shao2-debian>
Hello Marc,
On 29/07/2019 11.41, kernel test robot wrote:
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: 60649d4e0af6c26b6c423dea9c57f39e823fc0c5 ("can: remove obsolete empty ioctl() handler")
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git master
the kernel test robot is right.
The patch ("can: remove obsolete empty ioctl() handler") leads to a
return value of -EOPNOTSUPP instead of the former -ENOIOCTLCMD.
As we can see in socket.c ...
https://elixir.bootlin.com/linux/v5.3-rc2/source/net/socket.c#L1041
/*
* If this ioctl is unknown try to hand it down
* to the NIC driver.
*/
if (err != -ENOIOCTLCMD)
return err;
... we need to return -ENOIOCTLCMD to pass the SIOCGIFINDEX ioctl to the
NIC layer.
Therefore the entire commit needs to be *reverted* to restore the
required functionality.
> If you fix the issue, kindly add following tag
> Reported-by: kernel test robot <rong.a.chen@intel.com>
Many thanks,
Oliver
prev parent reply other threads:[~2019-07-29 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 9:41 [can] 60649d4e0a: ltp.can_rcv_own_msgs.fail kernel test robot
2019-07-29 14:13 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786568d6-bd24-327a-8367-319efbe2cccb@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=ltp@lists.linux.it \
--cc=mkl@pengutronix.de \
--cc=rong.a.chen@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).