From: "Alex G." <mr.nuke.me@gmail.com>
To: Shiju Jose <shiju.jose@huawei.com>, "bp@alien8.de" <bp@alien8.de>
Cc: "alex_gagniuc@dellteam.com" <alex_gagniuc@dellteam.com>,
"austin_bolen@dell.com" <austin_bolen@dell.com>,
"shyam_iyer@dell.com" <shyam_iyer@dell.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Erik Schmauss <erik.schmauss@intel.com>,
Tyler Baicar <tbaicar@codeaurora.org>,
Will Deacon <will.deacon@arm.com>,
James Morse <james.morse@arm.com>,
"Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>,
gengdongjiu <gengdongjiu@huawei.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>
Subject: Re: [RFC PATCH v4 2/3] acpi: apei: Rename ghes_severity() to ghes_cper_severity()
Date: Fri, 4 May 2018 18:33:03 -0500 [thread overview]
Message-ID: <796c5f59-ec98-0fca-a9de-012057506843@gmail.com> (raw)
In-Reply-To: <86258A5CC0A3704780874CF6004BA8A64EE2C974@FRAEML521-MBX.china.huawei.com>
On 05/04/2018 06:56 AM, Shiju Jose wrote:
> Hi Alex,
Hi
>> -----Original Message-----
>> From: Alexandru Gagniuc [mailto:mr.nuke.me@gmail.com]
[snip]
>> -static inline int ghes_severity(int severity)
>> +static inline int ghes_cper_severity(int severity)
>
> [...]
>> else
>> ratelimit = &ratelimit_uncorrected;
>> @@ -705,9 +705,8 @@ static int ghes_proc(struct ghes *ghes)
>> if (rc)
>> goto out;
>>
>> - if (ghes_severity(ghes->estatus->error_severity) >=
>> GHES_SEV_PANIC) {
>> + if (ghes_cper_severity(ghes->estatus->error_severity) >=
>> GHES_SEV_PANIC)
>> __ghes_panic(ghes);
>
> PCIe AER fatal errors result panic here.
> I think ghes_cper_severity to be replaced with ghes_severity in the ghes_proc function as well in the patch
> "acpi: apei: Do not panic() on PCIe errors reported through GHES"?
Hmm.
ghes_proc calls ghes_do_proc, which is not irq safe. So the entire
concern we had in v1 about deferring to a less restrictive context is
moot in this case.
ghes_proc is related, but a little beyond the scope of this series. I'd
love to fix all cases, but I'd prefer someone who has specific interests
take ownership of changing ghes_proc.
Alex
next prev parent reply other threads:[~2018-05-04 23:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180430212836.7807-1-mr.nuke.me@gmail.com>
2018-04-30 21:33 ` [RFC PATCH v4 1/3] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error Alexandru Gagniuc
2018-04-30 21:33 ` [RFC PATCH v4 2/3] acpi: apei: Rename ghes_severity() to ghes_cper_severity() Alexandru Gagniuc
2018-05-04 11:56 ` Shiju Jose
2018-05-04 23:33 ` Alex G. [this message]
2018-05-11 15:39 ` Borislav Petkov
2018-05-11 15:45 ` Alex G.
2018-05-11 15:58 ` Borislav Petkov
2018-05-11 16:12 ` Alex G.
2018-05-11 16:19 ` Borislav Petkov
2018-05-11 17:03 ` Alex G.
2018-04-30 21:33 ` [RFC PATCH v4 3/3] acpi: apei: Do not panic() on PCIe errors reported through GHES Alexandru Gagniuc
2018-05-11 15:40 ` Borislav Petkov
2018-05-11 15:54 ` Alex G.
2018-05-11 16:02 ` Borislav Petkov
2018-05-11 16:12 ` Alex G.
2018-05-11 16:29 ` Borislav Petkov
2018-05-11 17:01 ` Alex G.
2018-05-11 17:41 ` Borislav Petkov
2018-05-11 17:56 ` Alex G.
2018-05-12 9:00 ` [RFC PATCH v4 1/3] EDAC, GHES: Remove unused argument to ghes_edac_report_mem_error Borislav Petkov
2018-05-14 14:59 ` [PATCH v5 0/2] acpi: apei: Improve PCIe error handling with FFS Alexandru Gagniuc
2018-05-14 14:59 ` [PATCH v5 1/2] acpi: apei: Rename ghes_severity() to ghes_cper_severity() Alexandru Gagniuc
2018-05-14 14:59 ` [PATCH v5 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES Alexandru Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=796c5f59-ec98-0fca-a9de-012057506843@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bp@alien8.de \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=gengdongjiu@huawei.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=shiju.jose@huawei.com \
--cc=shyam_iyer@dell.com \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).