From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: robert.foss@linaro.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
open list <linux-kernel@vger.kernel.org>,
"open list:QUALCOMM CAMERA SUBSYSTEM DRIVER"
<linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Todor Tomov <todor.too@gmail.com>
Subject: Re: [PATCH 00/17] CAMSS: SM8250 support (and some fixes)
Date: Wed, 16 Jun 2021 21:16:42 +0300 [thread overview]
Message-ID: <7a9b847c-34b8-c9ca-8232-88b6ecb23ff5@linaro.org> (raw)
In-Reply-To: <20210608223513.23193-1-jonathan@marek.ca>
Hi Jonathan,
I've given this patchset a try on RB3 board (SDM845) with ov8856 camera sensor - works OK,
no regressions.
Thanks,
Andrey
On 09.06.2021 01:34, Jonathan Marek wrote:
> This adds initial support for SM8250 and its 4 VFEs and 6 CSIPHYs.
> The only big change is the added camss-vfe-480.c to support the
> Titan 480 VFE.
>
> v2:
> - Fixed some typos in commit messages (patches 02 and 08)
> - patch 03 ("media: camss: csiphy-3ph: add support for SM8250 CSI DPHY"):
> - moved definition of CAMSS_8250 to this patch,
> - removed unused lane_enable variable
> - added a default unreachable case to avoid a warning
> - added a is_gen2 variable (minor rework)
> - Undo DECODE_FORMAT_PAYLOAD_ONLY change, add comment instead (patch 04)
> - "ops" reworks in addition to removing dead code (patch 12)
> - renamed csid-170 to csid-gen2, added defines for offsets, add missing
> camnoc_axi clock to sm8250 vfe resources (patch 16/17)
>
> Jonathan Marek (17):
> media: camss: csiphy-3ph: don't print HW version as an error
> media: camss: csiphy-3ph: disable interrupts
> media: camss: csiphy-3ph: add support for SM8250 CSI DPHY
> media: camss: csid-170: fix non-10bit formats
> media: camss: csid-170: don't enable unused irqs
> media: camss: csid-170: remove stray comment
> media: camss: csid-170: support more than one lite vfe
> media: camss: csid-170: set the right HALT_CMD when disabled
> media: camss: csid: allow csid to work without a regulator
> media: camss: remove vdda-csiN from sdm845 resources
> media: camss: fix VFE irq name
> media: camss: remove some vfe ops and clean up dead vfe-170 code
> media: camss: vfe-170: fix "VFE halt timeout" error
> media: camss: Add initial support for VFE hardware version Titan 480
> media: camss: add support for V4L2_PIX_FMT_GREY for sdm845 HW
> media: camss: add support for SM8250 camss
> media: dt-bindings: media: camss: Add qcom,sm8250-camss binding
>
> .../bindings/media/qcom,sm8250-camss.yaml | 399 +++++++++++++
> drivers/media/platform/qcom/camss/Makefile | 3 +-
> .../{camss-csid-170.c => camss-csid-gen2.c} | 32 +-
> .../media/platform/qcom/camss/camss-csid.c | 45 +-
> .../media/platform/qcom/camss/camss-csid.h | 2 +-
> .../qcom/camss/camss-csiphy-3ph-1-0.c | 184 ++++--
> .../media/platform/qcom/camss/camss-csiphy.c | 9 +-
> .../media/platform/qcom/camss/camss-vfe-170.c | 101 +---
> .../media/platform/qcom/camss/camss-vfe-4-1.c | 25 +-
> .../media/platform/qcom/camss/camss-vfe-4-7.c | 63 +-
> .../media/platform/qcom/camss/camss-vfe-4-8.c | 65 +--
> .../media/platform/qcom/camss/camss-vfe-480.c | 545 ++++++++++++++++++
> .../platform/qcom/camss/camss-vfe-gen1.c | 94 +--
> .../platform/qcom/camss/camss-vfe-gen1.h | 39 +-
> drivers/media/platform/qcom/camss/camss-vfe.c | 29 +-
> drivers/media/platform/qcom/camss/camss-vfe.h | 17 +-
> .../media/platform/qcom/camss/camss-video.c | 5 +-
> drivers/media/platform/qcom/camss/camss.c | 205 ++++++-
> drivers/media/platform/qcom/camss/camss.h | 1 +
> 19 files changed, 1523 insertions(+), 340 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> rename drivers/media/platform/qcom/camss/{camss-csid-170.c => camss-csid-gen2.c} (95%)
> create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-480.c
>
next prev parent reply other threads:[~2021-06-16 18:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 22:34 [PATCH 00/17] CAMSS: SM8250 support (and some fixes) Jonathan Marek
2021-06-08 22:34 ` [PATCH 01/17] media: camss: csiphy-3ph: don't print HW version as an error Jonathan Marek
2021-06-08 22:34 ` [PATCH 02/17] media: camss: csiphy-3ph: disable interrupts Jonathan Marek
2021-06-08 22:34 ` [PATCH 03/17] media: camss: csiphy-3ph: add support for SM8250 CSI DPHY Jonathan Marek
2021-06-08 22:34 ` [PATCH 04/17] media: camss: csid-170: fix non-10bit formats Jonathan Marek
2021-06-08 22:34 ` [PATCH 05/17] media: camss: csid-170: don't enable unused irqs Jonathan Marek
2021-06-08 22:34 ` [PATCH 06/17] media: camss: csid-170: remove stray comment Jonathan Marek
2021-06-08 22:34 ` [PATCH 07/17] media: camss: csid-170: support more than one lite vfe Jonathan Marek
2021-06-08 22:34 ` [PATCH 08/17] media: camss: csid-170: set the right HALT_CMD when disabled Jonathan Marek
2021-06-08 22:34 ` [PATCH 09/17] media: camss: csid: allow csid to work without a regulator Jonathan Marek
2021-06-10 8:01 ` Robert Foss
2021-06-08 22:34 ` [PATCH 10/17] media: camss: remove vdda-csiN from sdm845 resources Jonathan Marek
2021-06-08 22:35 ` [PATCH 11/17] media: camss: fix VFE irq name Jonathan Marek
2021-06-08 22:35 ` [PATCH 12/17] media: camss: remove some vfe ops and clean up dead vfe-170 code Jonathan Marek
2021-06-09 3:23 ` kernel test robot
2021-06-10 5:23 ` kernel test robot
2021-06-10 12:37 ` Robert Foss
2021-06-08 22:35 ` [PATCH 13/17] media: camss: vfe-170: fix "VFE halt timeout" error Jonathan Marek
2021-06-08 22:35 ` [PATCH 14/17] media: camss: Add initial support for VFE hardware version Titan 480 Jonathan Marek
2021-06-10 12:40 ` Robert Foss
2021-06-08 22:35 ` [PATCH 15/17] media: camss: add support for V4L2_PIX_FMT_GREY for sdm845 HW Jonathan Marek
2021-06-08 22:35 ` [PATCH 16/17] media: camss: add support for SM8250 camss Jonathan Marek
2021-06-10 8:03 ` Robert Foss
2021-06-08 22:35 ` [PATCH 17/17] media: dt-bindings: media: camss: Add qcom,sm8250-camss binding Jonathan Marek
2021-06-09 16:16 ` Rob Herring
2021-06-09 22:10 ` Rob Herring
2021-06-09 22:32 ` Jonathan Marek
2021-06-16 18:16 ` Andrey Konovalov [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-11 18:07 [PATCH 00/17] CAMSS: SM8250 support (and some fixes) Jonathan Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a9b847c-34b8-c9ca-8232-88b6ecb23ff5@linaro.org \
--to=andrey.konovalov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).