From: Yann Droneaud <ydroneaud@opteya.com>
To: Christian Brauner <christian@brauner.io>
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, jannh@google.com,
fweimer@redhat.com, oleg@redhat.com, arnd@arndb.de,
dhowells@redhat.com, Pavel Emelyanov <xemul@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Adrian Reber <adrian@lisas.de>, Andrei Vagin <avagin@gmail.com>,
linux-api@vger.kernel.org
Subject: Re: [PATCH v1 1/2] fork: add clone3
Date: Sat, 01 Jun 2019 10:49:38 +0200 [thread overview]
Message-ID: <7ba353ba112ebbe1493fcc210795cf74a0e83f74.camel@opteya.com> (raw)
In-Reply-To: <20190531220815.owrc5kbbdemmwdhs@brauner.io>
Hi,
Le samedi 01 juin 2019 à 00:08 +0200, Christian Brauner a écrit :
> On Wed, May 29, 2019 at 05:42:14PM +0200, Yann Droneaud wrote:
> > Le mercredi 29 mai 2019 à 17:22 +0200, Christian Brauner a écrit :
> > > This adds the clone3 system call.
> > >
> > >
> > > diff --git a/kernel/fork.c b/kernel/fork.c
> > > index b4cba953040a..6bc3e3d17150 100644
> > > --- a/kernel/fork.c
> > > +++ b/kernel/fork.c
> > > @@ -2472,7 +2475,96 @@ SYSCALL_DEFINE5(clone, unsigned long,
> > > clone_flags, unsigned long, newsp,
> > > unsigned long, tls)
> > > #endif
> > > {
> > > - return _do_fork(clone_flags, newsp, 0, parent_tidptr,
> > > child_tidptr, tls);
> > > + struct kernel_clone_args args = {
> > > + .flags = clone_flags,
> > > + .stack = newsp,
> > > + .pidfd = parent_tidptr,
> > > + .parent_tidptr = parent_tidptr,
> > > + .tls = tls,
> > > + .child_tidptr = child_tidptr,
> > > + };
> > > +
> > > + /* clone(CLONE_PIDFD) uses parent_tidptr to return a pidfd */
> > > + if ((clone_flags & CLONE_PIDFD) && (clone_flags &
> > > CLONE_PARENT_SETTID))
> > > + return -EINVAL;
> > > +
> > > + return _do_fork(&args);
> > > +}
> > > +
> > > +static bool clone3_flags_valid(u64 flags)
> > > +{
> > > + if (flags & CLONE_DETACHED)
> > > + return false;
> > > +
> > > + if (flags & ~CLONE_MAX)
> > > + return false;
> > > +
> > > + return true;
> > > +}
> > > +
> > > +static int copy_clone_args_from_user(struct kernel_clone_args
> > > *kargs,
> > > + struct clone_args __user *uargs,
> > > + size_t size)
> > > +{
> > > + struct clone_args args;
> > > +
> > > + if (unlikely(size > PAGE_SIZE))
> > > + return -E2BIG;
> > > +
> > > + if (unlikely(size < sizeof(struct clone_args)))
> > > + return -EINVAL;
> > > +
> > > + if (unlikely(!access_ok(uargs, size)))
> > > + return -EFAULT;
> > > +
> > > + if (size > sizeof(struct clone_args)) {
> > > + unsigned char __user *addr;
> > > + unsigned char __user *end;
> > > + unsigned char val;
> > > +
> > > + addr = (void __user *)uargs + sizeof(struct
> > > clone_args);
> > > + end = (void __user *)uargs + size;
> > > +
> > > + for (; addr < end; addr++) {
> > > + if (get_user(val, addr))
> > > + return -EFAULT;
> > > + if (val)
> > > + return -E2BIG;
> >
> > Should be -EINVAL: having something after the structure should be
> > handled just like an invalid flags, while still allowing future
> > userspace program to probe for support for newer feature.
>
> (Traveling until Monday, so sorry for delayed responses.)
>
> This copies what:
>
> kernel/sched/core.c:sched_copy_attr()
> kernel/event/core.c:perf_copy_attr()
>
> are already doing. Consistency might be good here but, I think.
>
I would have prefer all the above to returns -EINVAL for consistency
with the unknown flags check ...
"Designing the API: Planning for Extension" [1] doesn't mandate return
-EINVAL for that case, but does make perf_event_open() and
perf_copy_attr() the example to follow ... so you're right.
[1]
https://www.kernel.org/doc/html/v5.1/process/adding-syscalls.html#designing-the-api-planning-for-extension
Regards.
--
Yann Droneaud
OPTEYA
next prev parent reply other threads:[~2019-06-01 8:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 15:22 [PATCH v1 1/2] fork: add clone3 Christian Brauner
2019-05-29 15:22 ` [PATCH v1 2/2] arch: wire-up clone3() syscall on x86 Christian Brauner
2019-05-29 15:42 ` [PATCH v1 1/2] fork: add clone3 Yann Droneaud
2019-05-31 22:08 ` Christian Brauner
2019-06-01 8:49 ` Yann Droneaud [this message]
2019-05-29 22:24 ` Andrei Vagin
2019-05-31 20:38 ` Linus Torvalds
2019-05-31 22:13 ` Christian Brauner
2019-05-31 22:08 ` Christian Brauner
2019-05-30 13:20 ` Szabolcs Nagy
2019-05-31 8:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba353ba112ebbe1493fcc210795cf74a0e83f74.camel@opteya.com \
--to=ydroneaud@opteya.com \
--cc=adrian@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=avagin@gmail.com \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=fweimer@redhat.com \
--cc=jannh@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).