From: "Sven Peter" <sven@svenpeter.dev>
To: "Hector Martin" <marcan@marcan.st>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Guido Günther" <agx@sigxcpu.org>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] usb: typec: tipd: Fixes for Apple M1 (CD321X) support
Date: Wed, 17 Nov 2021 19:19:49 +0100 [thread overview]
Message-ID: <7bac877d-1929-4caf-be8d-8405c5cfd3ba@www.fastmail.com> (raw)
In-Reply-To: <20211117151450.207168-1-marcan@marcan.st>
On Wed, Nov 17, 2021, at 16:14, Hector Martin wrote:
> Hi folks,
>
> These two fixes make tipd work properly on Apple M1 devices, in
> particular in the case where the bootloader hasn't initialized
> the controllers yet.
>
> We normally do it in m1n1 (so the machine can charge and so bootloaders
> get working USB without needing this driver), but that was causing this
> codepath to never get properly exercised, so we never caught it. I
My boot process usually is iBoot -> m1n1 on nvme -> m1n1 chainloaded over usb.
I thought I exercised this path by turning off the init in m1n1. I didn't take
into account that this would only affect the one loaded over usb and that
the one on nvme would still intitialize everything.
Thanks for fixing this!
With the Fixes tags feel free to add
Reviewed-by: Sven Peter <sven@svenpeter.dev>
to both patches.
Sven
prev parent reply other threads:[~2021-11-17 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 15:14 [PATCH 0/2] usb: typec: tipd: Fixes for Apple M1 (CD321X) support Hector Martin
2021-11-17 15:14 ` [PATCH 1/2] usb: typec: tipd: Fix typo in cd321x_switch_power_state Hector Martin
2021-11-17 16:03 ` Greg Kroah-Hartman
2021-11-17 16:07 ` Hector Martin
2021-11-18 13:05 ` Heikki Krogerus
2021-11-17 15:14 ` [PATCH 2/2] usb: typec: tipd: Fix initialization sequence for cd321x Hector Martin
2021-11-17 16:04 ` Greg Kroah-Hartman
2021-11-17 16:11 ` Hector Martin
2021-11-18 13:12 ` Heikki Krogerus
2021-11-20 3:08 ` Hector Martin
2021-11-17 18:19 ` Sven Peter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bac877d-1929-4caf-be8d-8405c5cfd3ba@www.fastmail.com \
--to=sven@svenpeter.dev \
--cc=agx@sigxcpu.org \
--cc=alyssa@rosenzweig.io \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcan@marcan.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).