From: John Crispin <john@phrozen.org>
To: Colin King <colin.king@canonical.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc
Date: Fri, 23 Dec 2016 06:38:45 +0100 [thread overview]
Message-ID: <7ca20b25-60d8-b439-0e30-671549d641bb@phrozen.org> (raw)
In-Reply-To: <20161222235258.5525-1-colin.king@canonical.com>
On 23/12/2016 00:52, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ralink_soc sould be assigned to RT3883_SOC, replace incorrect
> comparision with assignment.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: John Crispin <john@phrozen.org>
i thought i had sent this fix upstream ages ago. luckily this bug never
caused any error as none of the code checking ralink_soc checks for
rt3883. its used for the rt3x5x family.
John
> ---
> arch/mips/ralink/rt3883.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
> index 141c597..f869052 100644
> --- a/arch/mips/ralink/rt3883.c
> +++ b/arch/mips/ralink/rt3883.c
> @@ -157,5 +157,5 @@ void prom_soc_init(struct ralink_soc_info *soc_info)
>
> rt2880_pinmux_data = rt3883_pinmux_data;
>
> - ralink_soc == RT3883_SOC;
> + ralink_soc = RT3883_SOC;
> }
>
his
prev parent reply other threads:[~2016-12-23 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 23:52 [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc Colin King
2016-12-23 5:38 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ca20b25-60d8-b439-0e30-671549d641bb@phrozen.org \
--to=john@phrozen.org \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).