Re: [PATCH 02/13] drm/radeon: Eliminate possible use of an uninitialized variable

From: Neil Armstrong <narmstrong@baylibre.com>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
	dri-devel@lists.freedesktop.org
Cc: "David Airlie" <airlied@linux.ie>,
	"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Mamta Shukla" <mamtashukla555@gmail.com>,
	kernel@collabora.com, "Anthony Koo" <Anthony.Koo@amd.com>,
	linux-samsung-soc@vger.kernel.org,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"David Francis" <David.Francis@amd.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	linux-rockchip@lists.infradead.org,
	"Kukjin Kim" <kgene@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	linux-tegra@vger.kernel.org, "Leo Li" <sunpeng.li@amd.com>,
	linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org, "Jyri Sarha" <jsarha@ti.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Sean Paul" <sean@poorly.run>,
	"Allison Randal" <allison@lohutok.net>,
	amd-gfx@lists.freedesktop.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
	"Todor Tomov" <todor.tomov@linaro.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 02/13] drm/radeon: Eliminate possible use of an uninitialized variable
Date: Thu, 1 Aug 2019 14:15:15 +0200	[thread overview]
Message-ID: <7cacac43-737e-1ddb-2951-394fcf9ad0b2@baylibre.com> (raw)
In-Reply-To: <cfff357a07bfa572baad058947f281b7095e1794.1564591626.git.andrzej.p@collabora.com>

Hi Andrzej,

I had to revert the previous patch, so you should re-spin it entirely :

================================
After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/radeon/radeon_connectors.c: In function 'radeon_add_legacy_connector':
drivers/gpu/drm/radeon/radeon_connectors.c:2433:5: error: 'ddc' undeclared (first use in this function)
     ddc = &radeon_connector->ddc_bus->adapter;
     ^~~
drivers/gpu/drm/radeon/radeon_connectors.c:2433:5: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  bed7a2182de6 ("drm/radeon: Provide ddc symlink in connector sysfs directory")

I have used the drm-misc tree from next-20190731 for today.
==================================

Neil

On 31/07/2019 18:58, Andrzej Pietrasiewicz wrote:
> ddc local variable is passed to drm_connector_init_with_ddc() and should
> be NULL if no ddc is available.
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> ---
>  drivers/gpu/drm/radeon/radeon_connectors.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index b3ad8d890801..d11131d03ed6 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -1870,7 +1870,7 @@ radeon_add_atom_connector(struct drm_device *dev,
>  	struct radeon_connector_atom_dig *radeon_dig_connector;
>  	struct drm_encoder *encoder;
>  	struct radeon_encoder *radeon_encoder;
> -	struct i2c_adapter *ddc;
> +	struct i2c_adapter *ddc = NULL;
>  	uint32_t subpixel_order = SubPixelNone;
>  	bool shared_ddc = false;
>  	bool is_dp_bridge = false;
> 