From: Bart Van Assche <bvanassche@acm.org>
To: Evan Green <evgreen@chromium.org>, Jens Axboe <axboe@kernel.dk>,
Martin K Petersen <martin.petersen@oracle.com>
Cc: Gwendal Grignou <gwendal@chromium.org>,
Christoph Hellwig <hch@infradead.org>,
Ming Lei <ming.lei@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Alexis Savery <asavery@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] loop: Report EOPNOTSUPP properly
Date: Mon, 2 Dec 2019 16:48:56 -0800 [thread overview]
Message-ID: <7d4508c7-a3fc-67f6-392e-50a6247898aa@acm.org> (raw)
In-Reply-To: <20191114154903.v7.1.I0b2734bafaa1bd6831dec49cdb4730d04be60fc8@changeid>
On 11/14/19 3:50 PM, Evan Green wrote:
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index ef6e251857c8..6a9fe1f9fe84 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -461,7 +461,7 @@ static void lo_complete_rq(struct request *rq)
> if (!cmd->use_aio || cmd->ret < 0 || cmd->ret == blk_rq_bytes(rq) ||
> req_op(rq) != REQ_OP_READ) {
> if (cmd->ret < 0)
> - ret = BLK_STS_IOERR;
> + ret = errno_to_blk_status(cmd->ret);
> goto end_io;
> }
>
> @@ -1950,7 +1950,10 @@ static void loop_handle_cmd(struct loop_cmd *cmd)
> failed:
> /* complete non-aio request */
> if (!cmd->use_aio || ret) {
> - cmd->ret = ret ? -EIO : 0;
> + if (ret == -EOPNOTSUPP)
> + cmd->ret = ret;
> + else
> + cmd->ret = ret ? -EIO : 0;
> blk_mq_complete_request(rq);
> }
> }
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2019-12-03 0:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 23:50 [PATCH v7 0/2] loop: Better discard for block devices Evan Green
2019-11-14 23:50 ` [PATCH v7 1/2] loop: Report EOPNOTSUPP properly Evan Green
2019-12-02 17:05 ` Gwendal Grignou
2019-12-03 0:48 ` Bart Van Assche [this message]
2019-11-14 23:50 ` [PATCH v7 2/2] loop: Better discard support for block devices Evan Green
2019-11-20 2:25 ` Darrick J. Wong
2019-11-20 18:56 ` Evan Green
2019-11-20 19:13 ` Darrick J. Wong
2019-11-20 19:25 ` Evan Green
2019-11-20 19:45 ` Darrick J. Wong
2019-11-21 21:18 ` Evan Green
2019-11-21 21:25 ` Darrick J. Wong
2019-11-21 22:35 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d4508c7-a3fc-67f6-392e-50a6247898aa@acm.org \
--to=bvanassche@acm.org \
--cc=asavery@chromium.org \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).