From: "Michael Niewöhner" <linux@mniewoehner.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, jgg@ziepe.ca,
arnd@arndb.de, linux-integrity@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working
Date: Sun, 11 Nov 2018 21:09:19 +0100 [thread overview]
Message-ID: <7d8cc5ad4bb7548d283f363de6f24c90d5d0a2b2.camel@mniewoehner.de> (raw)
In-Reply-To: <1541962653.3190.7.camel@HansenPartnership.com>
On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote:
> On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote:
> [...]
> > > However, this makes me wonder about yours:
> > >
> > > > [ 0.003517] ACPI: TPM2 0x000000009E490ED8 000034 (v03 LENOVO
> > > > TC-
> > > > S06 00001300 AMI 00000000)
> > >
> > > I thought the Lenovo "upgrade to 2.0" in fact disabled the external
> > > TPM in favour of the Intel PTT (software TPM in the management
> > > engine). Since you apparently have the tpm_crb driver that should
> > > find the PTT TPM, this might be one of the attachment bugs in the
> > > CRB driver ... from your ACPI output it looks to be not specifying
> > > the Tpm2Tabl.
> >
> > Well, there are at least two implementations I know of:
> > For my Lenovo X260 I can choose between Infineon TPM 1.2 or Intel PTT
> > TPM 2.0 This here is my ThinkStation P320 which can choose between
> > PTT 1.2, PTT 2.0,
> > Nuvoton 1.2 and 2.0. When switchting between 1.2 and 2.0 the Nuvoton
> > gets
> > reflashed with the appropriate firmware.
>
> Well, I still think the ACPI setup is incorrect. What's in
> /sys/class/platform (should be directories of ACPI devices)? The TPM
> is supposed to show up as MSFT0101. If it doesn't is there any other
> device string in there that might be a TPM?
Nope. I'm not sure if it should show up in ACPI... isn't TPM 2.0 I2C?
$ find /sys | grep -i tpm
/sys/class/tpmrm
/sys/class/tpm
/sys/bus/platform/drivers/tpm_tis
/sys/bus/platform/drivers/tpm_tis/uevent
/sys/bus/platform/drivers/tpm_tis/bind
/sys/bus/platform/drivers/tpm_tis/unbind
/sys/bus/pnp/drivers/tpm_tis
/sys/bus/pnp/drivers/tpm_tis/uevent
/sys/bus/pnp/drivers/tpm_tis/bind
/sys/bus/pnp/drivers/tpm_tis/unbind
/sys/bus/acpi/drivers/tpm_crb
/sys/bus/acpi/drivers/tpm_crb/uevent
/sys/bus/acpi/drivers/tpm_crb/bind
/sys/bus/acpi/drivers/tpm_crb/unbind
/sys/bus/i2c/drivers/tpm_i2c_nuvoton
/sys/bus/i2c/drivers/tpm_i2c_nuvoton/uevent
/sys/bus/i2c/drivers/tpm_i2c_nuvoton/bind
/sys/bus/i2c/drivers/tpm_i2c_nuvoton/unbind
>
> James
>
next prev parent reply other threads:[~2018-11-11 20:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 17:55 [BUG] Nuvoton NCPT650 TPM 2.0 mode not working Michael Niewöhner
2018-11-11 18:24 ` James Bottomley
2018-11-11 18:50 ` Michael Niewöhner
2018-11-11 18:57 ` James Bottomley
2018-11-11 20:09 ` Michael Niewöhner [this message]
2018-11-11 20:29 ` James Bottomley
2018-11-11 20:34 ` Michael Niewöhner
2018-11-11 21:11 ` Michael Niewöhner
2018-11-11 21:42 ` Mimi Zohar
2018-11-14 20:46 ` Michael Niewöhner
2018-11-16 21:06 ` Michael Niewöhner
2018-11-18 8:18 ` Jarkko Sakkinen
2018-11-18 14:10 ` Michael Niewöhner
2018-11-19 13:49 ` Jarkko Sakkinen
2018-11-25 20:06 ` Michael Niewöhner
2018-11-26 19:15 ` Michael Niewöhner
2018-11-26 21:13 ` Jarkko Sakkinen
2018-11-13 10:50 ` Jarkko Sakkinen
2019-01-11 15:40 ` Mimi Zohar
2019-01-12 9:52 ` Michael Niewöhner
2019-01-12 10:49 ` Michael Niewöhner
2018-11-11 18:33 ` Mimi Zohar
2018-11-11 18:51 ` Michael Niewöhner
2018-11-13 10:28 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8cc5ad4bb7548d283f363de6f24c90d5d0a2b2.camel@mniewoehner.de \
--to=linux@mniewoehner.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).