From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>
Subject: Re: [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs
Date: Sun, 2 Jul 2017 00:14:18 +0800 [thread overview]
Message-ID: <7e818878-875a-57ec-00cc-2d08fbc245d8@kernel.org> (raw)
In-Reply-To: <20170701074804.GB85052@jaegeuk-macbookpro.roam.corp.google.com>
On 2017/7/1 15:48, Jaegeuk Kim wrote:
> On 06/29, Chao Yu wrote:
>> From: Chao Yu <yuchao0@huawei.com>
>>
>> Don't clear old mount option before parse new option during ->remount_fs
>> like other generic filesystems>
> So, what happened on your original patch?
>
> commit 26666c8a4366debae30ae37d0688b2bec92d196a
> f2fs: fix to clean previous mount option when remount_fs
>
> I think we need to rever the original patch tho.
I just removed this for passing some quota testcases in xfstests suit,
and after that, I didn't get further failures in other testcases.
Let me check this again.
Thanks,
>
> Thanks,
>
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/super.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index f27c141cd8aa..af472f7968d0 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -846,7 +846,6 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
>> clear_sbi_flag(sbi, SBI_NEED_SB_WRITE);
>> }
>>
>> - sbi->mount_opt.opt = 0;
>> default_options(sbi);
>>
>> /* parse mount options */
>> --
>> 2.13.0.90.g1eb437020
next prev parent reply other threads:[~2017-07-01 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 15:20 [PATCH 1/2] f2fs: skip ->writepages for {mete,node}_inode during recovery Chao Yu
2017-06-29 15:20 ` [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs Chao Yu
2017-07-01 7:48 ` Jaegeuk Kim
2017-07-01 16:14 ` Chao Yu [this message]
2017-07-05 4:05 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e818878-875a-57ec-00cc-2d08fbc245d8@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).