From: Jason Wang <jasowang@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com,
mst@redhat.com, tiwei.bie@intel.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, cohuck@redhat.com,
maxime.coquelin@redhat.com, cunming.liang@intel.com,
zhihong.wang@intel.com, rob.miller@broadcom.com,
xiao.w.wang@intel.com, haotian.wang@sifive.com,
zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com,
oberpar@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
akrowiak@linux.ibm.com, freude@linux.ibm.com,
lingshan.zhu@intel.com, idos@mellanox.com, eperezma@redhat.com,
lulu@redhat.com, parav@mellanox.com,
christophe.de.dinechin@gmail.com, kevin.tian@intel.com,
stefanha@redhat.com
Subject: Re: [PATCH V5 2/6] modpost: add support for mdev class id
Date: Fri, 25 Oct 2019 09:44:05 +0800 [thread overview]
Message-ID: <7eb2c515-74a9-7d65-e09c-dee4f952e9c1@redhat.com> (raw)
In-Reply-To: <20191024135441.160daa56@x1.home>
On 2019/10/25 上午3:54, Alex Williamson wrote:
> On Thu, 24 Oct 2019 11:31:04 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
>> On 2019/10/24 上午5:42, Alex Williamson wrote:
>>> On Wed, 23 Oct 2019 21:07:48 +0800
>>> Jason Wang <jasowang@redhat.com> wrote:
>>>
>>>> Add support to parse mdev class id table.
>>>>
>>>> Reviewed-by: Parav Pandit <parav@mellanox.com>
>>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>>> ---
>>>> drivers/vfio/mdev/vfio_mdev.c | 2 ++
>>>> scripts/mod/devicetable-offsets.c | 3 +++
>>>> scripts/mod/file2alias.c | 10 ++++++++++
>>>> 3 files changed, 15 insertions(+)
>>>>
>>>> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
>>>> index 7b24ee9cb8dd..cb701cd646f0 100644
>>>> --- a/drivers/vfio/mdev/vfio_mdev.c
>>>> +++ b/drivers/vfio/mdev/vfio_mdev.c
>>>> @@ -125,6 +125,8 @@ static const struct mdev_class_id id_table[] = {
>>>> { 0 },
>>>> };
>>>>
>>>> +MODULE_DEVICE_TABLE(mdev, id_table);
>>>> +
>>> Two questions, first we have:
>>>
>>> #define MODULE_DEVICE_TABLE(type, name) \
>>> extern typeof(name) __mod_##type##__##name##_device_table \
>>> __attribute__ ((unused, alias(__stringify(name))))
>>>
>>> Therefore we're defining __mod_mdev__id_table_device_table with alias
>>> id_table. When the virtio mdev bus driver is added in 5/6 it uses the
>>> same name value. I see virtio types all register this way (virtio,
>>> id_table), so I assume there's no conflict, but pci types mostly (not
>>> entirely) seem to use unique names. Is there a preference to one way
>>> or the other or it simply doesn't matter?
>>
>> It looks to me that those symbol were local, so it doesn't matter. But
>> if you wish I can switch to use unique name.
> I don't have a strong opinion, I'm just trying to make sure we're not
> doing something obviously broken.
Yes, to be more safe I will switch to unique names here.
>
>>>> static struct mdev_driver vfio_mdev_driver = {
>>>> .name = "vfio_mdev",
>>>> .probe = vfio_mdev_probe,
>>>> diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetable-offsets.c
>>>> index 054405b90ba4..6cbb1062488a 100644
>>>> --- a/scripts/mod/devicetable-offsets.c
>>>> +++ b/scripts/mod/devicetable-offsets.c
>>>> @@ -231,5 +231,8 @@ int main(void)
>>>> DEVID(wmi_device_id);
>>>> DEVID_FIELD(wmi_device_id, guid_string);
>>>>
>>>> + DEVID(mdev_class_id);
>>>> + DEVID_FIELD(mdev_class_id, id);
>>>> +
>>>> return 0;
>>>> }
>>>> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
>>>> index c91eba751804..d365dfe7c718 100644
>>>> --- a/scripts/mod/file2alias.c
>>>> +++ b/scripts/mod/file2alias.c
>>>> @@ -1335,6 +1335,15 @@ static int do_wmi_entry(const char *filename, void *symval, char *alias)
>>>> return 1;
>>>> }
>>>>
>>>> +/* looks like: "mdev:cN" */
>>>> +static int do_mdev_entry(const char *filename, void *symval, char *alias)
>>>> +{
>>>> + DEF_FIELD(symval, mdev_class_id, id);
>>>> +
>>>> + sprintf(alias, "mdev:c%02X", id);
>>> A lot of entries call add_wildcard() here, should we? Sorry for the
>>> basic questions, I haven't played in this code. Thanks,
>>
>> It's really good question. My understanding is we won't have a module
>> that can deal with all kinds of classes like CLASS_ID_ANY. So there's
>> probably no need for the wildcard.
> The comment for add_wildcard() indicates future extension, so it's hard
> to know what we might need in the future until we do need it. The
> majority of modules.alias entries on my laptop (even if I exclude pci
> aliases) end with a wildcard. Thanks,
Yes, so I will add that for future extension.
Thanks
>
> Alex
>
next prev parent reply other threads:[~2019-10-25 1:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 13:07 [PATCH V5 0/6] mdev based hardware virtio offloading support Jason Wang
2019-10-23 13:07 ` [PATCH V5 1/6] mdev: class id support Jason Wang
2019-10-23 16:30 ` Parav Pandit
2019-10-23 21:42 ` Alex Williamson
2019-10-24 3:27 ` Jason Wang
2019-10-24 19:46 ` Alex Williamson
2019-10-24 20:13 ` Alex Williamson
2019-10-25 1:42 ` Jason Wang
2019-10-23 13:07 ` [PATCH V5 2/6] modpost: add support for mdev class id Jason Wang
2019-10-23 21:42 ` Alex Williamson
2019-10-24 3:31 ` Jason Wang
2019-10-24 19:54 ` Alex Williamson
2019-10-25 1:44 ` Jason Wang [this message]
2019-10-23 13:07 ` [PATCH V5 3/6] mdev: introduce device specific ops Jason Wang
2019-10-23 13:07 ` [PATCH V5 4/6] mdev: introduce virtio device and its device ops Jason Wang
2019-10-23 21:57 ` Alex Williamson
2019-10-24 3:51 ` Jason Wang
2019-10-24 20:44 ` Alex Williamson
2019-10-25 1:54 ` Jason Wang
2019-10-29 7:42 ` Zhu Lingshan
2019-10-29 10:42 ` Jason Wang
2019-10-30 7:36 ` Zhu Lingshan
2019-10-23 13:07 ` [PATCH V5 5/6] virtio: introduce a mdev based transport Jason Wang
2019-10-23 13:07 ` [PATCH V5 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eb2c515-74a9-7d65-e09c-dee4f952e9c1@redhat.com \
--to=jasowang@redhat.com \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=christophe.de.dinechin@gmail.com \
--cc=cohuck@redhat.com \
--cc=cunming.liang@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=farman@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=haotian.wang@sifive.com \
--cc=heiko.carstens@de.ibm.com \
--cc=idos@mellanox.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=parav@mellanox.com \
--cc=pasic@linux.ibm.com \
--cc=rob.miller@broadcom.com \
--cc=rodrigo.vivi@intel.com \
--cc=sebott@linux.ibm.com \
--cc=stefanha@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiao.w.wang@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).