From: Mirela Rabulea <mirela.rabulea@nxp.com>
To: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"laurent.pinchart+renesas@ideasonboard.com"
<laurent.pinchart+renesas@ideasonboard.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Laurentiu Palcu <laurentiu.palcu@nxp.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Robert Chiras <robert.chiras@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"paul.kocialkowski@bootlin.com" <paul.kocialkowski@bootlin.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"niklas.soderlund+renesas@ragnatech.se"
<niklas.soderlund+renesas@ragnatech.se>,
Daniel Baluta <daniel.baluta@nxp.com>,
"dafna.hirschfeld@collabora.com" <dafna.hirschfeld@collabora.com>,
"ezequiel@collabora.com" <ezequiel@collabora.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Subject: Re: [EXT] Re: [PATCH v9 6/8] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder
Date: Thu, 11 Mar 2021 09:12:31 +0000 [thread overview]
Message-ID: <7ff5f190c66159773c67a1b4fc73e00751fb9c28.camel@nxp.com> (raw)
In-Reply-To: <58f6d308-c5c7-f2a0-9c64-b729282c9b71@xs4all.nl>
On Thu, 2021-03-11 at 08:27 +0100, Hans Verkuil wrote:
> Caution: EXT Email
>
> Hi Mirela,
>
> On 11/03/2021 01:28, Mirela Rabulea (OSS) wrote:
>
> <snip>
>
> > +static const struct of_device_id mxc_jpeg_match[] = {
> > + {
> > + .compatible = "nxp,imx8qxp-jpgdec",
> > + .data = (void *)MXC_JPEG_DECODE,
>
> Don't do this, just say:
>
> static const int mxc_decode_mode = MXC_JPEG_DECODE;
> static const int mxc_encode_mode = MXC_JPEG_ENCODE;
>
> and point to that:
>
> .data = &mxc_decode_mode;
>
> > + },
> > + {
> > + .compatible = "nxp,imx8qxp-jpgenc",
> > + .data = (void *)MXC_JPEG_ENCODE,
>
> .data = &mxc_encode_mode;
>
> > + },
> > + { },
> > +};
>
> <snip>
>
> > +static int mxc_jpeg_probe(struct platform_device *pdev)
> > +{
> > + struct mxc_jpeg_dev *jpeg;
> > + struct device *dev = &pdev->dev;
> > + struct resource *res;
> > + int dec_irq;
> > + int ret;
> > + int mode;
> > + const struct of_device_id *of_id;
> > + unsigned int slot;
> > +
> > + of_id = of_match_node(mxc_jpeg_match, dev->of_node);
> > + mode = (int)(u64)of_id->data;
>
> and this becomes:
>
> mode = *(const int *)of_id->data;
>
> This will solve the kernel test robot warning, and for that matter
> the same gcc warnings I get when I compile.
Hi Hans,
thanks for the suggestion, I missed that warning among the verbosity
from the other ones. Perhaps for the future it would be usefull for me
to try and replicate the kernel test robot environment.
I sent v9.1 just for this patch.
Regards,
Mirela
>
> Just post a v9.1 for this patch, everything else looks good.
>
> Regards,
>
> Hans
next prev parent reply other threads:[~2021-03-11 9:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 0:28 [PATCH v9 0/8] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2021-03-11 0:28 ` [PATCH v9 1/8] media: v4l: Add packed YUV444 24bpp pixel format Mirela Rabulea (OSS)
2021-03-11 0:28 ` [PATCH v9 2/8] media: dt-bindings: Add bindings for i.MX8QXP/QM JPEG driver Mirela Rabulea (OSS)
2021-03-11 0:28 ` [PATCH v9 3/8] media: Add parsing for APP14 data segment in jpeg helpers Mirela Rabulea (OSS)
2021-03-11 0:28 ` [PATCH v9 4/8] media: Quit parsing stream if doesn't start with SOI Mirela Rabulea (OSS)
2021-03-11 0:28 ` [PATCH v9 5/8] media: Avoid parsing quantization and huffman tables Mirela Rabulea (OSS)
2021-03-11 0:28 ` [PATCH v9 6/8] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2021-03-11 2:49 ` kernel test robot
2021-03-11 7:27 ` Hans Verkuil
2021-03-11 9:12 ` Mirela Rabulea [this message]
2021-03-11 0:28 ` [PATCH v9 7/8] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes Mirela Rabulea (OSS)
2021-03-11 11:01 ` Hans Verkuil
2021-03-12 10:36 ` Aisheng Dong
2021-03-11 0:28 ` [PATCH v9 8/8] Add maintainer for IMX jpeg v4l2 driver Mirela Rabulea (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ff5f190c66159773c67a1b4fc73e00751fb9c28.camel@nxp.com \
--to=mirela.rabulea@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurentiu.palcu@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).