From: Rik van Riel <riel@surriel.com>
To: Song Liu <songliubraving@fb.com>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: matthew.wilcox@oracle.com, kirill.shutemov@linux.intel.com,
kernel-team@fb.com, william.kucharski@oracle.com,
akpm@linux-foundation.org, hdanton@sina.com
Subject: Re: [PATCH v9 6/6] mm,thp: avoid writes to file with THP in pagecache
Date: Thu, 27 Jun 2019 09:18:35 -0400 [thread overview]
Message-ID: <8026a0341c83ceee69d04cbe55f1e0fa3d6cb610.camel@surriel.com> (raw)
In-Reply-To: <20190625001246.685563-7-songliubraving@fb.com>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On Mon, 2019-06-24 at 17:12 -0700, Song Liu wrote:
> In previous patch, an application could put part of its text section
> in
> THP via madvise(). These THPs will be protected from writes when the
> application is still running (TXTBSY). However, after the application
> exits, the file is available for writes.
>
> This patch avoids writes to file THP by dropping page cache for the
> file
> when the file is open for write. A new counter nr_thps is added to
> struct
> address_space. In do_last(), if the file is open for write and
> nr_thps
> is non-zero, we drop page cache for the whole file.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Acked-by: Rik van Riel <riel@surriel.com>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-27 13:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 0:12 [PATCH v9 0/6] Enable THP for text section of non-shmem files Song Liu
2019-06-25 0:12 ` [PATCH v9 1/6] filemap: check compound_head(page)->mapping in filemap_fault() Song Liu
2019-07-10 17:44 ` Johannes Weiner
2019-07-10 17:51 ` Johannes Weiner
2019-06-25 0:12 ` [PATCH v9 2/6] filemap: update offset check " Song Liu
2019-07-10 17:52 ` Johannes Weiner
2019-06-25 0:12 ` [PATCH v9 3/6] mm,thp: stats for file backed THP Song Liu
2019-07-10 17:59 ` Johannes Weiner
2019-06-25 0:12 ` [PATCH v9 4/6] khugepaged: rename collapse_shmem() and khugepaged_scan_shmem() Song Liu
2019-06-27 13:19 ` Rik van Riel
2019-07-10 18:21 ` Johannes Weiner
2019-06-25 0:12 ` [PATCH v9 5/6] mm,thp: add read-only THP support for (non-shmem) FS Song Liu
2019-07-10 18:48 ` Johannes Weiner
2019-07-22 23:41 ` Song Liu
2019-07-23 23:59 ` Huang, Kai
2019-07-28 6:41 ` Song Liu
2019-06-25 0:12 ` [PATCH v9 6/6] mm,thp: avoid writes to file with THP in pagecache Song Liu
2019-06-27 13:18 ` Rik van Riel [this message]
2019-07-10 19:11 ` Johannes Weiner
2019-06-27 12:46 ` [PATCH v9 0/6] Enable THP for text section of non-shmem files Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8026a0341c83ceee69d04cbe55f1e0fa3d6cb610.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=kernel-team@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).