From: "Heiko Stübner" <heiko@sntech.de>
To: Artem Lapkin <email2tema@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
art@khadas.com, jbx6244@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, nick@khadas.com
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node
Date: Wed, 23 Sep 2020 12:57:56 +0200 [thread overview]
Message-ID: <8046326.tZ3HhvINgq@diego> (raw)
In-Reply-To: <20200923101225.1513392-2-email2tema@gmail.com>
Hi Artem,
please make the subject something like
"arm64: dts: rockchip: add spiflash node to rk3399-khadas-edge"
Am Mittwoch, 23. September 2020, 12:12:24 CEST schrieb Artem Lapkin:
> From: Artem Lapkin <art@khadas.com>
>
> The Khadas Edge Boards uses winbond - w25q128 spi flash with 104Mhz
Missing "Signed-off-by: ..."
> ---
> .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> index e36837c04dc..42ebbd6fa46 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> @@ -805,3 +805,17 @@ &vopl {
> &vopl_mmu {
> status = "okay";
> };
> +
> +
no double empty lines please
> +&spi1 {
please group the &spi1 alphabetically in the file
> + max-freq = <104000000>;
not part of any binding, spi-max-frequency below should be enough.
> + status = "okay";
> +
> + spiflash: flash@0 {
> + u-boot,dm-pre-reloc;
u-boot specific, please drop
> + compatible = "winbond,w25q128fw", "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <104000000>;
> + };
> +};
> +
>
Heiko
next prev parent reply other threads:[~2020-09-23 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:12 [PATCH 0/2] arm64: dts: rockchip: rk3399-khadas-edge: missed nodes Artem Lapkin
2020-09-23 10:12 ` [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node Artem Lapkin
2020-09-23 10:57 ` Heiko Stübner [this message]
2020-09-23 10:12 ` [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes Artem Lapkin
2020-09-23 11:02 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8046326.tZ3HhvINgq@diego \
--to=heiko@sntech.de \
--cc=art@khadas.com \
--cc=devicetree@vger.kernel.org \
--cc=email2tema@gmail.com \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).