From: Tero Kristo <t-kristo@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
"open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM"
<linux-remoteproc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
Suman Anna <s-anna@ti.com>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 01/17] dt-bindings: remoteproc: Add OMAP remoteproc bindings
Date: Wed, 6 Nov 2019 15:50:35 +0200 [thread overview]
Message-ID: <80d28cf5-1219-fb49-a416-5a879f719ebd@ti.com> (raw)
In-Reply-To: <CAL_JsqJd_wDMVgFkMRZ7_+0hz93zqJFWEQXY-Sn+3tT-urzRKA@mail.gmail.com>
On 06/11/2019 15:27, Rob Herring wrote:
> On Wed, Nov 6, 2019 at 6:44 AM Tero Kristo <t-kristo@ti.com> wrote:
>>
>> On 06/11/2019 05:27, Rob Herring wrote:
>>> On Mon, Oct 28, 2019 at 02:42:22PM +0200, Tero Kristo wrote:
>>>> From: Suman Anna <s-anna@ti.com>
>>>>
>>>> Add the device tree bindings document for the IPU and DSP
>>>> remote processor devices on OMAP4+ SoCs.
>>>>
>>>> Cc: Rob Herring <robh@kernel.org>
>>>> Cc: devicetree@vger.kernel.org
>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>>>> ---
>>>> .../remoteproc/ti,omap-remoteproc.txt | 205 ++++++++++++++++++
>>>> 1 file changed, 205 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt
>>>>
>>>
>>> Looks to be in pretty good shape, but how about doing a schema.
>>
>> iommu / mailbox is not in schema format, can I just convert this one to
>> schema without considering those? If yes, I can go ahead and do it.
>
> The client side both have schema (in dt-schema repo).
>
>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt
>>>> new file mode 100644
>>>> index 000000000000..e2bcfcab21c1
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt
>>>> @@ -0,0 +1,205 @@
>>>> +OMAP4+ Remoteproc Devices
>>>> +=========================
>>>> +
>>>> +The OMAP family of SoCs usually have one or more slave processor sub-systems
>>>> +that are used to offload some of the processor-intensive tasks, or to manage
>>>> +other hardware accelerators, for achieving various system level goals.
>>>> +
>>>> +The processor cores in the sub-system are usually behind an IOMMU, and may
>>>> +contain additional sub-modules like Internal RAM and/or ROMs, L1 and/or L2
>>>> +caches, an Interrupt Controller, a Cache Controller etc.
>>>> +
>>>> +The OMAP SoCs usually have a DSP processor sub-system and/or an IPU processor
>>>> +sub-system. The DSP processor sub-system can contain any of the TI's C64x,
>>>> +C66x or C67x family of DSP cores as the main execution unit. The IPU processor
>>>> +sub-system usually contains either a Dual-Core Cortex-M3 or Dual-Core Cortex-M4
>>>> +processors.
>>>> +
>>>> +Remote Processor Node:
>>>> +======================
>>>> +Each remote processor sub-system is represented as a single DT node. Each node
>>>> +has a number of required or optional properties that enable the OS running on
>>>> +the host processor (MPU) to perform the device management of the remote
>>>> +processor and to communicate with the remote processor. The various properties
>>>> +can be classified as constant or variable. The constant properties are dictated
>>>> +by the SoC and does not change from one board to another having the same SoC.
>>>> +Examples of constant properties include 'iommus', 'reg'. The variable properties
>>>> +are dictated by the system integration aspects such as memory on the board, or
>>>> +configuration used within the corresponding firmware image. Examples of variable
>>>> +properties include 'mboxes', 'memory-region', 'timers', 'watchdog-timers' etc.
>>>> +
>>>> +Required properties:
>>>> +--------------------
>>>> +The following are the mandatory properties:
>>>> +
>>>> +- compatible: Should be one of the following,
>>>> + "ti,omap4-dsp" for DSPs on OMAP4 SoCs
>>>> + "ti,omap5-dsp" for DSPs on OMAP5 SoCs
>>>> + "ti,dra7-dsp" for DSPs on DRA7xx/AM57xx SoCs
>>>> + "ti,omap4-ipu" for IPUs on OMAP4 SoCs
>>>> + "ti,omap5-ipu" for IPUs on OMAP5 SoCs
>>>> + "ti,dra7-ipu" for IPUs on DRA7xx/AM57xx SoCs
>>>> +
>>>> +- iommus: phandles to OMAP IOMMU nodes, that need to be programmed
>>>> + for this remote processor to access any external RAM memory or
>>>> + other peripheral device address spaces. This property usually
>>>> + has only a single phandle. Multiple phandles are used only in
>>>> + cases where the sub-system has different ports for different
>>>> + sub-modules within the processor sub-system (eg: DRA7 DSPs),
>>>> + and need the same programming in both the MMUs.
>>
>> ^ the target of this is not in schema.
>
> You mean the OMAP IOMMU binding? That doesn't matter at all.
Yeah, OMAP IOMMU.
Ok, if it does not matter, I will just convert this all. Will send v2
once I am done.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-11-06 13:50 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 12:42 [PATCH 00/17] remoteproc: omap changes on top of v5.4-rc1 Tero Kristo
2019-10-28 12:42 ` [PATCH 01/17] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo
2019-11-06 3:27 ` Rob Herring
2019-11-06 12:44 ` Tero Kristo
2019-11-06 13:27 ` Rob Herring
2019-11-06 13:50 ` Tero Kristo [this message]
2019-11-07 14:05 ` [PATCHv2 " Tero Kristo
2019-11-13 14:25 ` Rob Herring
2019-10-28 12:42 ` [PATCH 02/17] remoteproc/omap: Switch to SPDX license identifiers Tero Kristo
2019-11-09 1:03 ` Bjorn Andersson
2019-11-12 8:16 ` Tero Kristo
2019-12-20 3:30 ` Suman Anna
2019-10-28 12:42 ` [PATCH 03/17] remoteproc/omap: Add device tree support Tero Kristo
2019-11-11 23:16 ` Bjorn Andersson
2019-11-12 8:14 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 04/17] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo
2019-11-11 23:18 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 05/17] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo
2019-11-11 23:21 ` Bjorn Andersson
2019-11-12 8:21 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 06/17] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo
2019-11-11 23:22 ` Bjorn Andersson
2019-11-12 8:22 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 07/17] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo
2019-11-11 23:23 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 08/17] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo
2019-11-11 23:37 ` Bjorn Andersson
2019-11-12 8:37 ` Tero Kristo
2019-11-12 18:13 ` Bjorn Andersson
2019-11-13 8:08 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 09/17] remoteproc/omap: Remove the unused fields from platform data Tero Kristo
2019-11-11 23:37 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 10/17] remoteproc/omap: Remove the omap_rproc_reserve_cma declaration Tero Kristo
2019-11-11 23:37 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 11/17] remoteproc/omap: Check for undefined mailbox messages Tero Kristo
2019-11-11 23:39 ` Bjorn Andersson
2019-11-12 8:38 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 12/17] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo
2019-11-12 4:13 ` Bjorn Andersson
2019-11-12 8:42 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 13/17] remoteproc/omap: add support for system suspend/resume Tero Kristo
2019-11-12 6:15 ` Bjorn Andersson
2019-11-12 8:45 ` Tero Kristo
2019-11-12 18:06 ` Bjorn Andersson
2019-10-28 12:42 ` [PATCH 14/17] remoteproc/omap: add support for runtime auto-suspend/resume Tero Kristo
2019-10-28 12:42 ` [PATCH 15/17] remoteproc/omap: report device exceptions and trigger recovery Tero Kristo
2019-11-12 6:26 ` Bjorn Andersson
2019-11-12 8:46 ` Tero Kristo
2019-10-28 12:42 ` [PATCH 16/17] remoteproc/omap: add watchdog functionality for remote processors Tero Kristo
2019-10-28 12:42 ` [PATCH 17/17] remoteproc/omap: fix auto-suspend failure warning during crashed state Tero Kristo
2019-11-12 6:28 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80d28cf5-1219-fb49-a416-5a879f719ebd@ti.com \
--to=t-kristo@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).