From: Hannes Reinecke <hare@suse.com>
To: Jason Yan <yanaijie@huawei.com>,
martin.petersen@oracle.com, jejb@linux.vnet.ibm.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
john.garry@huawei.com, zhaohongjiang@huawei.com,
dan.j.williams@intel.com, jthumshirn@suse.de, hch@lst.de,
huangdaode@hisilicon.com, chenxiang66@hisilicon.com,
miaoxie@huawei.com, Ewan Milne <emilne@redhat.com>,
Tomas Henzl <thenzl@redhat.com>
Subject: Re: [PATCH 2/5] scsi: libsas: check the lldd callback correctly
Date: Mon, 17 Sep 2018 15:54:44 +0200 [thread overview]
Message-ID: <8114701f-be33-9c41-3ed7-e2a13490569d@suse.com> (raw)
In-Reply-To: <20180912082946.34814-3-yanaijie@huawei.com>
On 09/12/2018 10:29 AM, Jason Yan wrote:
> We are using lldd_port_deformed so we'd better check if lldd_port_deformed
> is NULL.
>
> After this, we can remove hisi_sas_port_deformed() because it is just a
> stub to avoid a NULL dereference caused by the wrong check.
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> CC: John Garry <john.garry@huawei.com>
> CC: Johannes Thumshirn <jthumshirn@suse.de>
> CC: Ewan Milne <emilne@redhat.com>
> CC: Christoph Hellwig <hch@lst.de>
> CC: Tomas Henzl <thenzl@redhat.com>
> CC: Dan Williams <dan.j.williams@intel.com>
> CC: Hannes Reinecke <hare@suse.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 9 ++-------
> drivers/scsi/libsas/sas_discover.c | 2 +-
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index a4e2e6aa9a6b..1975c9266978 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -1861,10 +1861,6 @@ static void hisi_sas_port_formed(struct asd_sas_phy *sas_phy)
> hisi_sas_port_notify_formed(sas_phy);
> }
>
> -static void hisi_sas_port_deformed(struct asd_sas_phy *sas_phy)
> -{
> -}
> -
> static int hisi_sas_write_gpio(struct sas_ha_struct *sha, u8 reg_type,
> u8 reg_index, u8 reg_count, u8 *write_data)
> {
> @@ -1954,10 +1950,9 @@ static struct sas_domain_function_template hisi_sas_transport_ops = {
> .lldd_I_T_nexus_reset = hisi_sas_I_T_nexus_reset,
> .lldd_lu_reset = hisi_sas_lu_reset,
> .lldd_query_task = hisi_sas_query_task,
> - .lldd_clear_nexus_ha = hisi_sas_clear_nexus_ha,
> + .lldd_clear_nexus_ha = hisi_sas_clear_nexus_ha,
> .lldd_port_formed = hisi_sas_port_formed,
> - .lldd_port_deformed = hisi_sas_port_deformed,
> - .lldd_write_gpio = hisi_sas_write_gpio,
> + .lldd_write_gpio = hisi_sas_write_gpio,
> };
>
> void hisi_sas_init_mem(struct hisi_hba *hisi_hba)
> diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
> index 0148ae62a52a..dde433aa59c2 100644
> --- a/drivers/scsi/libsas/sas_discover.c
> +++ b/drivers/scsi/libsas/sas_discover.c
> @@ -260,7 +260,7 @@ static void sas_suspend_devices(struct work_struct *work)
> * phy_list is not being mutated
> */
> list_for_each_entry(phy, &port->phy_list, port_phy_el) {
> - if (si->dft->lldd_port_formed)
> + if (si->dft->lldd_port_deformed)
> si->dft->lldd_port_deformed(phy);
> phy->suspended = 1;
> port->suspended = 1;
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
next prev parent reply other threads:[~2018-09-17 13:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 8:29 [PATCH 0/5] scsi: libsas: some code cleanups and bug fixes Jason Yan
2018-09-12 8:29 ` [PATCH 1/5] scsi: libsas: delete dead code in scsi_transport_sas.c Jason Yan
2018-09-17 8:35 ` John Garry
2018-09-17 13:53 ` Hannes Reinecke
2018-09-12 8:29 ` [PATCH 2/5] scsi: libsas: check the lldd callback correctly Jason Yan
2018-09-17 8:11 ` John Garry
2018-09-17 13:54 ` Hannes Reinecke [this message]
2018-09-12 8:29 ` [PATCH 3/5] scsi: libsas: always unregister the old device if going to discover new Jason Yan
2018-09-17 13:55 ` Hannes Reinecke
2018-09-12 8:29 ` [PATCH 4/5] scsi: libsas: check the ata device status by ata_dev_enabled() Jason Yan
2018-09-17 13:56 ` Hannes Reinecke
2018-09-18 13:54 ` John Garry
2018-09-19 2:54 ` Jason Yan
2018-09-12 8:29 ` [PATCH 5/5] scsi: libsas: fix a race condition when smp task timeout Jason Yan
2018-09-17 9:47 ` John Garry
2018-09-19 2:49 ` Jason Yan
2018-09-19 8:39 ` John Garry
2018-09-17 13:57 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8114701f-be33-9c41-3ed7-e2a13490569d@suse.com \
--to=hare@suse.com \
--cc=chenxiang66@hisilicon.com \
--cc=dan.j.williams@intel.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=huangdaode@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miaoxie@huawei.com \
--cc=thenzl@redhat.com \
--cc=yanaijie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).