From: Baolin Wang <baolin.wang@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, baolin.wang@linaro.org,
dan.carpenter@oracle.com
Subject: [PATCH] ASoC: sprd: Fix the smatch warning
Date: Wed, 3 Apr 2019 00:47:55 -0700 [thread overview]
Message-ID: <811e491489b62624942dabd56f277b08784ef0f9.1554276741.git.baolin.wang@linaro.org> (raw)
Remove the unnecessary validation of the 'cstream' variable to fix
below smatch warning:
sprd_platform_compr_drain_notify() warn: variable dereferenced
before check 'cstream' (see line 105)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
sound/soc/sprd/sprd-pcm-compress.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/sprd/sprd-pcm-compress.c b/sound/soc/sprd/sprd-pcm-compress.c
index dc84257..424e983 100644
--- a/sound/soc/sprd/sprd-pcm-compress.c
+++ b/sound/soc/sprd/sprd-pcm-compress.c
@@ -107,8 +107,7 @@ static void sprd_platform_compr_drain_notify(void *arg)
memset(stream->info_area, 0, sizeof(struct sprd_compr_playinfo));
- if (cstream)
- snd_compr_drain_notify(cstream);
+ snd_compr_drain_notify(cstream);
}
static void sprd_platform_compr_dma_complete(void *data)
--
1.9.1
next reply other threads:[~2019-04-03 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 7:47 Baolin Wang [this message]
2019-04-04 6:04 ` Applied "ASoC: sprd: Fix the smatch warning" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=811e491489b62624942dabd56f277b08784ef0f9.1554276741.git.baolin.wang@linaro.org \
--to=baolin.wang@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).