From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Jes Sorensen <jes.sorensen@gmail.com>, linux-kernel@vger.kernel.org
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] Mark expected switch fall-throughs and fix missing break
Date: Mon, 22 Oct 2018 16:53:49 +0200 [thread overview]
Message-ID: <8189d36d-1e12-c16d-4cb7-9aeefea3a6ff@embeddedor.com> (raw)
In-Reply-To: <a1b9b68a-ca94-f02f-4a87-bbd46782c41c@gmail.com>
On 10/22/18 4:36 PM, Jes Sorensen wrote:
> On 10/22/18 7:49 AM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, this patchset aims
>> to mark multiple switch cases where we are expecting to fall through.
>>
>> Also, the second patch in this series fixes a missing break in switch.
>
> Enabling that sounds like a great way to inflict pain and suffering.
>
Not really. The -Wimplicit-fallthrough will be enabled until after all the
current warnings have been addressed.
There are 600 of these issues left. So, hopefully I will complete this task
during the next development cycle.
Thanks
--
Gustavo
prev parent reply other threads:[~2018-10-22 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 11:49 [PATCH 0/2] Mark expected switch fall-throughs and fix missing break Gustavo A. R. Silva
2018-10-22 11:50 ` [PATCH 1/2] rtl8xxxu: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-11-06 16:59 ` Kalle Valo
2018-10-22 11:51 ` [PATCH 2/2] rtl8xxxu: Fix missing break in switch Gustavo A. R. Silva
2018-10-22 14:36 ` [PATCH 0/2] Mark expected switch fall-throughs and fix missing break Jes Sorensen
2018-10-22 14:53 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8189d36d-1e12-c16d-4cb7-9aeefea3a6ff@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=jes.sorensen@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).