From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>,
Patrick Lai <plai@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Ajit Pandey <ajitp@codeaurora.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Randy Dunlap <rdunlap@infradead.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: fix QDSP6 dependencies, attempt #3
Date: Fri, 4 Dec 2020 17:48:17 +0000 [thread overview]
Message-ID: <8323d386-c3f1-2db6-1870-2279784dd85e@linaro.org> (raw)
In-Reply-To: <20201203231443.1483763-1-arnd@kernel.org>
On 03/12/2020 23:14, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The previous fix left another warning in randconfig builds:
>
> WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n]
> Selected by [y]:
> - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]
>
> Add one more dependency for this one.
>
> Fixes: 2bc8831b135c ("ASoC: qcom: fix SDM845 & QDSP6 dependencies more")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the patch,
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 27f93006be96..cc7c1de2f1d9 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -106,6 +106,7 @@ config SND_SOC_QDSP6
> config SND_SOC_MSM8996
> tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
> depends on QCOM_APR
> + depends on COMMON_CLK
> select SND_SOC_QDSP6
> select SND_SOC_QCOM_COMMON
> help
>
next prev parent reply other threads:[~2020-12-04 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 23:14 [PATCH] ASoC: qcom: fix QDSP6 dependencies, attempt #3 Arnd Bergmann
2020-12-04 17:48 ` Srinivas Kandagatla [this message]
2020-12-04 23:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8323d386-c3f1-2db6-1870-2279784dd85e@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=rdunlap@infradead.org \
--cc=rohitkr@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).