From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161496AbcE3Piv (ORCPT ); Mon, 30 May 2016 11:38:51 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:60997 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932632AbcE3Pit (ORCPT ); Mon, 30 May 2016 11:38:49 -0400 From: Arnd Bergmann To: Tomasz Nowicki Cc: helgaas@kernel.org, will.deacon@arm.com, catalin.marinas@arm.com, rafael@kernel.org, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jchandra@broadcom.com, robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jcm@redhat.com, andrea.gallo@linaro.org, dhdang@apm.com, jeremy.linton@arm.com, liudongdong3@huawei.com, cov@codeaurora.org Subject: Re: [PATCH V8 9/9] pci, acpi: ARM64 support for ACPI based generic PCI host controller Date: Mon, 30 May 2016 17:38:13 +0200 Message-ID: <8385994.W7ve9PrvHG@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1464621262-26770-10-git-send-email-tn@semihalf.com> References: <1464621262-26770-1-git-send-email-tn@semihalf.com> <1464621262-26770-10-git-send-email-tn@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:iBQ/5kNTQJtbP+apI9v3wMTUwK+SXBPi1IS7zMWeRjluZpkzhnv psBrcvlu8Ur21AMRstSMCWocZw6MKx8lyKYR71ogwIVyg7Twq8Et4Dm3j9ga6jArJghpmLE AeqyPnwAESlQUU8S/PCJlKFqSf89MUxMynhuFgz1Pei3hnMOTFREMYWHV1FxXmR7vPBc4Kx B+J28P4Demssy5TGvnusQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:39lVz4Ija4s=:xMM1kzv7r0xD1g3XWn5gKe PKGaOAGYLy1v6hZEjWxrTvOijRF6Bo+JxJpBkGqY8AEnMdCnEUhWKpreNEJNd6lluCzSX+pzx YX7wmy4n2jjeiTNsgYU/lZcEYPcz04XEjY+SBqID6YM3RUmawfv7OCSghDxselSGaYusn2B+j FGrqim2Cvq2GzIfzdKN02GsXLk90XNneo7wWf7wV5s8pJIHs7fkVYTd8WBwZtb69sqnzTGBBs K0HPguv4KJ73wAMnJm1HpItpBX10i5xSV3aDrDNfrTRsm6q/HVTbjwIyiINTRxGaYSTPzmpvD Thg4c+qy8TCZKQKUNOTBnZiRUzKixVPIrGR7IYB8WU0fiTXqT4EiseKohbEjtFfl1iJtCO1tx +nAbhMaCQyE3t1nleXkXtIsYfEZkOtyQWyl4dCU15pdJP+lwk7NZ/xC3FYO7M4SwLtRejMeew p/QcvAWhTrepKutxnvM8wlDN3mXPyHR/o2BMO72Tm54lJ3SRHRtkoJqMFyDfv+AfsglgqFwkS 9FUYk4xYhlTIONxsnc8ScJY4pI+//mvXfegmDKjsf1BkfIrb2Uhf6MnQyGHCCNBoFuaiBRw7r c2d65DvxDzXOzCGJeamdgTOIOqGaRgVC+/WswBycFyUN1v2lte+C7QTMbxpf/DFRejJ5IymAK yMbBzbvG32KmPz2qH0kXWyhCjLBsjoNhNDLdE5Z1dBXyACGmqhqwSNSs1KnZ4TPQLENw0Rusl NupPG+9PMuYRIBey Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, May 30, 2016 5:14:22 PM CEST Tomasz Nowicki wrote: > + bsz = 1 << pci_generic_ecam_ops.bus_shift; > + cfgres.start = root->mcfg_addr + bus_res->start * bsz; > + cfgres.end = cfgres.start + resource_size(bus_res) * bsz - 1; > + cfgres.flags = IORESOURCE_MEM; > + cfg = pci_ecam_create(&root->device->dev, &cfgres, bus_res, > + &pci_generic_ecam_ops); > + if (IS_ERR(cfg)) { > + pr_err("%04x:%pR error %ld mapping CAM\n", seg, bus_res, > + PTR_ERR(cfg)); > + return PTR_ERR(cfg); > + } > + > + ri->cfg = cfg; > + return 0; > +} I wonder if we could do this a little simpler and just put a pointer to the mmconfig space into struct pci_host_bridge, and then have a trivial map_bus function alongside pci_generic_config_read/pci_generic_config_write. As this code is specific to arch/arm64, we don't need any of the complexity of drivers/pci/ecam.c, which basically only exists to work around the limited virtual address space of 32-bit machines. Arnd