From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E935CC433ED for ; Thu, 13 May 2021 15:07:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9B19610F7 for ; Thu, 13 May 2021 15:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233218AbhEMPI4 (ORCPT ); Thu, 13 May 2021 11:08:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232156AbhEMPIx (ORCPT ); Thu, 13 May 2021 11:08:53 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 726BAC061574 for ; Thu, 13 May 2021 08:07:43 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id j19so19942838qtp.7 for ; Thu, 13 May 2021 08:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=TLkSbdc1fw8jgiPXkD5Ij+EaQClDSHw8ek8z1tmir8s=; b=xLFFqHGJUuKACF0i4U8uJPm4Twx4FLRwFZ3bHS1rcLvjc7XLRx0eiQCtipmD/9Aj17 qp+yYqr0XN5FRLxDmsV5BWl9A0aVboKsjGCtUP7RloVY9soeG0cvxBMt5bGg8YB87XCV FQUVBvw3ujSSW5spSdxqiFA4Q+e0OVlHan1ttnh5RYd968dQG5+5Lwo0Dr5PS6Ko38Mj LIcJ2jpay7bZ9RsUhr1z1bxmuazuKOpn//ABPNBQMBpAg7YglmRbAjj7svL0pORUVg2o 7yuqP9/C/itpIXv1p5o34uXj01lDTBuiYfnZQeBeVWd6bYfyRb34Vr4AwjbM9+zl3lA0 gEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=TLkSbdc1fw8jgiPXkD5Ij+EaQClDSHw8ek8z1tmir8s=; b=UpgAp8EzPHcRi6VCwyA1HhgrK7NVE55HSx8E+ps9PjzmY7EOPSh5vAW7Ndn5qV0MyG 6NcZje+NccUPN39pAxZZsNBuYZqUsafQLZD0epusM62axyTQ04IxWgSC63Vv73ia45wW sBoTWYvsQzxYy5DU2U5sqpU/W8+5Pbv6ZkZHB2C6rA/0RbrmAs/1tmxgObM8FwRLECgI DF6qfh+96gRLVcycr6C8yf/1o1hN+Y1zSKkcz88NwcXGVw6Iidexre2Aeuv3gkS62Zum /glEmItLDCWer6mFlfpdIFaq8S9cMbPkD4jfglqB/xiX8K2S1m62mi5PxoHhxTSpRxSx ztYQ== X-Gm-Message-State: AOAM532ZKxfCrOtiP9+xfIbrdFxVdaof99bPMJAa/d+SNAkxLOYJI7sd /ki4RDlfwdqliWb6um5UxDmJTg== X-Google-Smtp-Source: ABdhPJzQjQznftnSoUznPn4Riax7X6sR3Jx0KiEsVldOVfBawDd633rhVFzGDWtrbUuPSud3+4cEsg== X-Received: by 2002:ac8:5dcc:: with SMTP id e12mr27252202qtx.70.1620918462544; Thu, 13 May 2021 08:07:42 -0700 (PDT) Received: from nicolas-tpx395.localdomain (mtl.collabora.ca. [66.171.169.34]) by smtp.gmail.com with ESMTPSA id h65sm2413773qkc.128.2021.05.13.08.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 08:07:42 -0700 (PDT) Message-ID: <83a807111f17c9e2db4e9f12a7ec1437c11d0f55.camel@ndufresne.ca> Subject: Re: [PATCH v4 07/15] media: mtk-vcodec: vdec: add media device if using stateless api From: Nicolas Dufresne To: Alexandre Courbot , Hans Verkuil Cc: Tiffany Lin , Andrew-CT Chen , Rob Herring , Yunfei Dong , Mauro Carvalho Chehab , Linux Media Mailing List , LKML , "moderated list:ARM/Mediatek SoC support" Date: Thu, 13 May 2021 11:07:40 -0400 In-Reply-To: References: <20210427111526.1772293-1-acourbot@chromium.org> <20210427111526.1772293-8-acourbot@chromium.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le jeudi 13 mai 2021 à 17:05 +0900, Alexandre Courbot a écrit : > Hi Hans, thanks for the review! > > On Thu, Apr 29, 2021 at 4:28 PM Hans Verkuil wrote: > > > > On 27/04/2021 13:15, Alexandre Courbot wrote: > > > From: Yunfei Dong > > > > > > The stateless API requires a media device for issuing requests. Add one > > > if we are being instantiated as a stateless decoder. > > > > Why for the stateless decoder only? Why not create one for all? > > > > It's not a blocker, but I would recommend looking at this. > > Would there be any use in creating a media device for a stateful > decoder that does not need to use requests? The only thing I can think of is classification. In GStreamer support for stateless decoders, I use the topology to classify what is a decoder by walking the toplogy and making sure it's what I expect, and that there is no other branches or functions that I may not support. This makes it more strict, so less likely to confuse driver function. Note that v4l2-compliance just use the same old heuristic we have used for stateful, which is to check that one side have only RAW format, and the other side have only encoded formats. It works too, it's just less strict. > > Cheers, > Alex.