From: "Saripalli, RK" <rsaripal@amd.com>
To: Borislav Petkov <bp@alien8.de>, Bandan Das <bsd@redhat.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
mingo@redhat.com, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 4/4] x86/speculation: Add PSF mitigation kernel parameters
Date: Wed, 21 Apr 2021 13:55:03 -0500 [thread overview]
Message-ID: <863ece71-463f-fc50-db13-7fd280902d6b@amd.com> (raw)
In-Reply-To: <20210421184826.GA3120@zn.tnic>
On 4/21/2021 1:48 PM, Borislav Petkov wrote:
> On Wed, Apr 21, 2021 at 02:32:13PM -0400, Bandan Das wrote:
>> Maybe, rename the parameter to something like psfd_disable, then off
>> -> disables mitigation and on -> enables it. Or just rewriting this to
>> off -> turns off predictive store forwarding is probably ok too.
>
> Yes:
>
> off - Turns off predictive store forwarding.
> on - Turns on...
>
> Ramakrishna, you don't have to call this a mitigation - this is a flag
> which controls the feature.
Agreed. I will fix it.
>
> Also, those 4 patches can be merged into a single one which simply adds
> the feature along with the boot-time controls.
I separated them into separate patches because the KVM patch depends on one of the patch.
The corresponding QEMU patch depends on another patch.
By separating them into 4 separate patches, my thinking was I could keep them logically separate.
Yes, I can combine all 4 patches into one patch but would like to get feedback before I do so.
>
> Thx.
>
next prev parent reply other threads:[~2021-04-21 18:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 9:01 [PATCH 0/4] Introduce support for PSF mitigation Ramakrishna Saripalli
2021-04-21 9:01 ` [PATCH 1/4] x86/cpufeatures: Define feature bits to support mitigation of PSF Ramakrishna Saripalli
2021-04-21 9:01 ` [PATCH 2/4] x86/speculation: Introduce SPEC_CTRL_MSR bit for PSFD Ramakrishna Saripalli
2021-04-21 9:01 ` [PATCH 3/4] x86/speculation: Implement PSF mitigation support Ramakrishna Saripalli
2021-04-21 9:01 ` [PATCH 4/4] x86/speculation: Add PSF mitigation kernel parameters Ramakrishna Saripalli
2021-04-21 16:04 ` Randy Dunlap
2021-04-21 18:32 ` Bandan Das
2021-04-21 18:36 ` Saripalli, RK
2021-04-21 18:48 ` Borislav Petkov
2021-04-21 18:55 ` Saripalli, RK [this message]
2021-04-21 18:57 ` Borislav Petkov
2021-04-21 19:05 ` Saripalli, RK
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863ece71-463f-fc50-db13-7fd280902d6b@amd.com \
--to=rsaripal@amd.com \
--cc=bp@alien8.de \
--cc=bsd@redhat.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).