From: Mike Tipton <mdtipton@codeaurora.org>
To: okukatla@codeaurora.org
Cc: djakov@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org,
saravanak@google.com, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
mdtipton=codeaurora.org@codeaurora.org
Subject: Re: [PATCH 1/4] interconnect: Zero initial BW after sync-state
Date: Mon, 12 Jul 2021 08:41:03 -0700 [thread overview]
Message-ID: <86e76352-1199-0fc6-9e5d-b7d45db37636@codeaurora.org> (raw)
In-Reply-To: <14c52b496918900c9cb3bef662a9e833@codeaurora.org>
On 7/1/2021 9:56 AM, okukatla@codeaurora.org wrote:
> On 2021-06-26 02:58, Mike Tipton wrote:
>> The initial BW values may be used by providers to enforce floors. Zero
>> these values after sync-state so that providers know when to stop
>> enforcing them.
>>
>> Fixes: b1d681d8d324 ("interconnect: Add sync state support")
>> Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
>> ---
>> drivers/interconnect/core.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
>> index 8a1e70e00876..945121e18b5c 100644
>> --- a/drivers/interconnect/core.c
>> +++ b/drivers/interconnect/core.c
>> @@ -1106,6 +1106,8 @@ void icc_sync_state(struct device *dev)
>> dev_dbg(p->dev, "interconnect provider is in synced state\n");
>> list_for_each_entry(n, &p->nodes, node_list) {
>> if (n->init_avg || n->init_peak) {
>> + n->init_avg = 0;
>> + n->init_peak = 0;
> nit: It is good to reset init/floor levels back to zero, but we don't
> need to do this as we have sync_state flag to let providers know when to
> stop enforcing.
The synced_state variable is static to this file. It's not exposed to
providers. In fact, we could entirely remove synced_state with this
patch since it's unnecessary after zeroing the initial floors.
>> aggregate_requests(n);
>> p->set(n, n);
>> }
next prev parent reply other threads:[~2021-07-12 15:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 21:28 [PATCH 0/4] interconnect: Fix sync-state issues Mike Tipton
2021-06-25 21:28 ` [PATCH 1/4] interconnect: Zero initial BW after sync-state Mike Tipton
2021-07-01 16:56 ` okukatla
2021-07-12 15:41 ` Mike Tipton [this message]
2021-06-25 21:28 ` [PATCH 2/4] interconnect: Always call pre_aggregate before aggregate Mike Tipton
2021-07-01 18:55 ` okukatla
2021-07-12 15:39 ` Mike Tipton
2021-06-25 21:28 ` [PATCH 3/4] interconnect: qcom: icc-rpmh: Ensure floor BW is enforced for all nodes Mike Tipton
2021-06-26 2:27 ` kernel test robot
2021-07-01 18:48 ` okukatla
2021-07-12 15:45 ` Mike Tipton
2021-06-25 21:28 ` [PATCH 4/4] interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate Mike Tipton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e76352-1199-0fc6-9e5d-b7d45db37636@codeaurora.org \
--to=mdtipton@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mdtipton=codeaurora.org@codeaurora.org \
--cc=okukatla@codeaurora.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).