From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1371DC43387 for ; Fri, 18 Jan 2019 11:10:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D56792087E for ; Fri, 18 Jan 2019 11:10:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="jti0xd7o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727304AbfARLKb (ORCPT ); Fri, 18 Jan 2019 06:10:31 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.50]:22939 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbfARLKa (ORCPT ); Fri, 18 Jan 2019 06:10:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1547809828; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=2S9cFsNirSbZDsyyIXpZo/RajCTM5g0kbSLyMuTyGW8=; b=jti0xd7oPd4/zLiq2X4NfVxz9GeNMbbcz0SNplxgZeplNLLHTzbP1md9kw9DFq4oim u6cFCYugTIuAePQH6wbhcvhU6IRZzGnnUsegJeNV0KSQhoieJyW7A5+REEZpU1wFzu5h YNEjbIeyKiX5MYA8xoUV9+U6DoJcqWEyFGAExLXE87I64idySYNEwF31EnJPMlUTD1OM SLHD6AKd4gBCFx+P2HNzZOA2WVp+bSdMJm1aLjIX7k2SQrYOdHA543RWjbvcLoiKJh5N lY5RxYvQd1N6G7LHCsG3+KDU7BLF3K0Y2pW31HRXRH1OV22Tao3l5Fza+WUaXF6SmYyg K+1w== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5G5MdirQj0WG7CkO3W1t7/x3Ry2nhljiBv4wW5sxWQ==" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:a400:162c:1cca:8712:d929:bc6d] by smtp.strato.de (RZmta 44.9 AUTH) with ESMTPSA id t0203dv0IBAQ92B (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 18 Jan 2019 12:10:26 +0100 (CET) Subject: Re: use generic DMA mapping code in powerpc V4 To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org References: <3504ee70-02de-049e-6402-2d530bf55a84@xenosoft.de> <23284859-bf0a-9cd5-a480-2a7fd7802056@xenosoft.de> <075f70e3-7a4a-732f-b501-05a1a8e3c853@xenosoft.de> <21f72a6a-9095-7034-f169-95e876228b2a@xenosoft.de> <27148ac2-2a92-5536-d886-2c0971ab43d9@xenosoft.de> <20190115133558.GA29225@lst.de> <685f0c06-af1b-0bec-ac03-f9bf1f7a2b35@xenosoft.de> <20190115151732.GA2325@lst.de> <20190118083539.GA30479@lst.de> From: Christian Zigotzky Message-ID: <871403f2-fa7d-de15-89eb-070432e15c69@xenosoft.de> Date: Fri, 18 Jan 2019 12:10:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190118083539.GA30479@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: de-DE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For which commit? -- Christian On 18 January 2019 at 09:35AM, Christoph Hellwig wrote: > Hi Christian, > > can you check if the debug printks in this patch trigger? > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 355d16acee6d..e46c9b64ec0d 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -118,8 +118,11 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > page = NULL; > } > } > - if (!page) > + if (!page) { > page = alloc_pages_node(dev_to_node(dev), gfp, page_order); > + if (!page) > + pr_warn("failed to allocate memory with gfp 0x%x\n", gfp); > + } > > if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { > __free_pages(page, page_order); > @@ -139,6 +142,10 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > } > } > > + if (!page) { > + pr_warn("failed to allocate DMA memory!\n"); > + dump_stack(); > + } > return page; > } > >