From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A79C433FF for ; Wed, 31 Jul 2019 14:02:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9869206A2 for ; Wed, 31 Jul 2019 14:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728902AbfGaOCI (ORCPT ); Wed, 31 Jul 2019 10:02:08 -0400 Received: from mga14.intel.com ([192.55.52.115]:44779 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbfGaOCI (ORCPT ); Wed, 31 Jul 2019 10:02:08 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 07:02:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,330,1559545200"; d="scan'208";a="196363057" Received: from um.fi.intel.com (HELO localhost) ([10.237.72.183]) by fmsmga004.fm.intel.com with ESMTP; 31 Jul 2019 07:02:06 -0700 From: Alexander Shishkin To: Peter Zijlstra Cc: Arnaldo Carvalho de Melo , Ingo Molnar , linux-kernel@vger.kernel.org, kan.liang@linux.intel.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH v1 2/7] perf/x86/intel: Support PEBS output to PT In-Reply-To: <20190729133705.GC31381@hirez.programming.kicks-ass.net> References: <20190704160024.56600-1-alexander.shishkin@linux.intel.com> <20190704160024.56600-3-alexander.shishkin@linux.intel.com> <20190729133705.GC31381@hirez.programming.kicks-ass.net> Date: Wed, 31 Jul 2019 17:02:05 +0300 Message-ID: <871ry6480y.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Thu, Jul 04, 2019 at 07:00:19PM +0300, Alexander Shishkin wrote: >> + /* >> + * In case there's a mix of PEBS->PT and PEBS->DS, fall back >> + * to DS. >> + */ > > I thought we disallowed that from happening !? Yes, that was a weird leftover. Thanks a bunch for the comments, they should all be addressed in v2: https://marc.info/?l=linux-kernel&m=156458152126310 Regards, -- Alex