From: Martyn Welch <martyn.welch@collabora.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Stefan Riedmüller" <s.riedmueller@phytec.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Christian Hemp" <c.hemp@phytec.de>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin
Date: Mon, 21 Jan 2019 09:40:54 +0000 [thread overview]
Message-ID: <8746aab308f76b4d8f33a20fea3f54da323832b3.camel@collabora.com> (raw)
In-Reply-To: <CAOMZO5ASTUDfKkghXq5FftM8-XNztXCYpmdOU9CVfyX3pgKxxA@mail.gmail.com>
Hi Fabio,
On Fri, 2019-01-18 at 19:18 -0200, Fabio Estevam wrote:
> diff --git a/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-
> > full.dts b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts
> > new file mode 100644
> > index 000000000000..83cdf4fa10c0
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts
> > @@ -0,0 +1,96 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2016 PHYTEC Messtechnik GmbH
> > + * Author: Christian Hemp <c.hemp@phytec.de>
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx6ul-phytec-pcl063.dtsi"
> > +#include "imx6ul-phytec-phyboard-segin.dtsi"
> > +#include "imx6ul-phytec-peb-eval-01.dtsi"
> > +
> > +/ {
> > + model = "Phytec phyBOARD-Segin i.MX6 UltraLite Full
> > Featured";
> > + compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul-
> > pcl063",
> > + "fsl,imx6ul";
>
> Better keep it in a single line?
>
It makes it longer than 80 chars, but I'm not adverse to that.
> > +&ecspi3 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_ecspi3>;
> > + cs-gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>;
> > + status = "okay";
> > +
> > + spidev@0 {
> > + compatible = "spidev";
>
> Doesn't the kernel complain about spidev dts nodes?
>
Oh, yes, it does when spidev is loaded...
Removing.
Martyn
next prev parent reply other threads:[~2019-01-21 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 19:48 [PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor Martyn Welch
2019-01-18 19:48 ` [PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin Martyn Welch
2019-01-18 21:18 ` Fabio Estevam
2019-01-21 9:40 ` Martyn Welch [this message]
2019-01-19 11:30 ` [PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8746aab308f76b4d8f33a20fea3f54da323832b3.camel@collabora.com \
--to=martyn.welch@collabora.com \
--cc=c.hemp@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s.riedmueller@phytec.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).