From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C287C433F5 for ; Thu, 10 Feb 2022 21:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344738AbiBJV6W (ORCPT ); Thu, 10 Feb 2022 16:58:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238245AbiBJV6U (ORCPT ); Thu, 10 Feb 2022 16:58:20 -0500 Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BA4EB37 for ; Thu, 10 Feb 2022 13:58:19 -0800 (PST) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JvrGW3Gdmz1s767; Thu, 10 Feb 2022 22:58:11 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JvrGW04bKz1qqkB; Thu, 10 Feb 2022 22:58:10 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id P0Gm9oQZh0uW; Thu, 10 Feb 2022 22:58:09 +0100 (CET) X-Auth-Info: K9Vgp8IFWJ4Z7781WVGKiz1IyIbMo3h9rBlVSRIGtFnKqw4w1utxrA8f7q6T64u9 Received: from igel.home (ppp-46-244-163-189.dynamic.mnet-online.de [46.244.163.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 10 Feb 2022 22:58:09 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 33DC02C3B35; Thu, 10 Feb 2022 22:58:09 +0100 (CET) From: Andreas Schwab To: Atish Patra Cc: linux-kernel@vger.kernel.org, Albert Ou , Atish Patra , Anup Patel , Damien Le Moal , devicetree@vger.kernel.org, Jisheng Zhang , Krzysztof Kozlowski , linux-riscv@lists.infradead.org, Palmer Dabbelt , Paul Walmsley , Rob Herring Subject: Re: [PATCH v2 5/6] RISC-V: Do no continue isa string parsing without correct XLEN References: <20220210214018.55739-1-atishp@rivosinc.com> <20220210214018.55739-6-atishp@rivosinc.com> X-Yow: I don't believe there really IS a GAS SHORTAGE.. I think it's all just a BIG HOAX on the part of the plastic sign salesmen-- .. to sell more numbers!! Date: Thu, 10 Feb 2022 22:58:09 +0100 In-Reply-To: <20220210214018.55739-6-atishp@rivosinc.com> (Atish Patra's message of "Thu, 10 Feb 2022 13:40:17 -0800") Message-ID: <877da2xu32.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 10 2022, Atish Patra wrote: > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > index 469b9739faf7..cca579bae8a0 100644 > --- a/arch/riscv/kernel/cpufeature.c > +++ b/arch/riscv/kernel/cpufeature.c > @@ -84,6 +84,7 @@ void __init riscv_fill_hwcap(void) > for_each_of_cpu_node(node) { > unsigned long this_hwcap = 0; > uint64_t this_isa = 0; > + char *temp; > > if (riscv_of_processor_hartid(node) < 0) > continue; > @@ -93,6 +94,7 @@ void __init riscv_fill_hwcap(void) > continue; > } > > + temp = (char *)isa; There should be no need for this cast. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."