From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22068C432BE for ; Mon, 9 Aug 2021 18:56:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0440260FE3 for ; Mon, 9 Aug 2021 18:56:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235728AbhHIS44 (ORCPT ); Mon, 9 Aug 2021 14:56:56 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:38174 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235246AbhHIS4z (ORCPT ); Mon, 9 Aug 2021 14:56:55 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1628535393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bO/dGC7/2zBF3jWQgAUjk/PLJ6l0svSy3Oj/4sUOHKw=; b=KCs3NOHY2utTiNmW6FlJhb38NQ6WjvmYVpRSDVwlTUNdUAKSE6rnflHY2RxJk8bIvfJMNM lCYb+OxqGPAy76Z21ivQLDkWcL61MUSwgsuKvhKc8OnRqZNFIaOoreZkLk8pWSu53e+d6a nrHAyf7t/Jvd7ObmhDU9ddgg/L0dCTB2ezAvowYQidbUivLPXcLz/REkWT+UQlXjRWgGQv ti6lWLuQEUdGvVt1irgaPytMqXjYIjaMNOKB4RWX8PVoqd9Q21/wB27G/wpxpip74V1MqE 0MzLVWwL5EUGuQ80HUSID0P4vIRx6W8PhinU+qOfegQmW1mEHI0SyfrS2IFYVA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1628535393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bO/dGC7/2zBF3jWQgAUjk/PLJ6l0svSy3Oj/4sUOHKw=; b=XqYpRWEwtWuPJr+5rOAj4VvKqQlEeEEqVOntY/PzebTwSeT/9hSM1EMc1XWcVtUKW48i13 11gt33xe7t/8JrAw== To: Marc Zyngier Cc: LKML , Alex Williamson , "Raj, Ashok" , "David S. Miller" , Bjorn Helgaas , linux-pci@vger.kernel.org, Kevin Tian , Ingo Molnar , x86@kernel.org, linux-s390@vger.kernel.org, Niklas Schnelle , Gerald Schaefer , Heiko Carstens , Christian Borntraeger Subject: Re: [patch V2 18/19] PCI/MSI: Provide a new set of mask and unmask functions In-Reply-To: <87r1f6bpt7.wl-maz@kernel.org> References: <20210729215139.889204656@linutronix.de> <20210729222543.257079238@linutronix.de> <87r1f6bpt7.wl-maz@kernel.org> Date: Mon, 09 Aug 2021 20:56:32 +0200 Message-ID: <878s1atpjz.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06 2021 at 15:39, Marc Zyngier wrote: > On Thu, 29 Jul 2021 22:51:57 +0100, > Thomas Gleixner wrote: >> +static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask) >> +{ >> + if (pci_msi_ignore_mask || desc->msi_attrib.is_virtual) >> + return; >> + >> + if (desc->msi_attrib.is_msix) >> + pci_msix_mask(desc); >> + else if (!desc->msi_attrib.maskbit) > > This negation is preventing one of my boxes from working correctly (no > idea why the i350 driver refuses to use MSI-X and sticks to a single > MSI, but hey, that's another story), as the device supports MSI > masking, and we definitely don't try to mask/unmask in this case... > > Dropping the '!' here and on the unmask path fixes it for me. Duh. I'm a moron. Of course this needs to check maskbit if it wants to mask. Sigh.