From: ebiederm@xmission.com (Eric W. Biederman)
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [CFT][PATCH] signal/usb: Replace kill_pid_info_as_cred with kill_pid_usb_asyncio
Date: Sat, 18 May 2019 10:25:05 -0500 [thread overview]
Message-ID: <878sv3ss32.fsf@xmission.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1905181116330.7855-100000@netrider.rowland.org> (Alan Stern's message of "Sat, 18 May 2019 11:20:47 -0400 (EDT)")
Alan Stern <stern@rowland.harvard.edu> writes:
> On Fri, 17 May 2019, Eric W. Biederman wrote:
>
>> Wow I got a little distracted but now I am back to this.
>>
>> Using your test program I was able to test the basics of this.
>>
>> I found one bug in my patch where I was missing a memset. So I have
>> corrected that, and reorganized the patch a little bit.
>>
>> I have not figured out how to trigger a usb disconnect so I have not
>> tested that.
>
> Heh. Assuming the device file you tell the test program to use
> corresponds to an actual USB device, you can trigger a disconnect by
> literally unplugging the USB cable. (Add a 10-second delay to the
> program to give yourself enough time.)
I have just been running this in qemu. But yes. I suppose the easy
way would be to print a message asking the usb device to be unplugged
and then just wait for the signal. I might try that.
>> The big thing I have not been able to test is running a 64bit big-endian
>> kernel with a 32bit user space. My modified version of your test
>> program should report "Bad" without my patch, and should report "Good"
>> with it.
>>
>> Is there any chance you can test that configuration? I could not figure
>> out how to get a 64bit big-endian system running in qemu, and I don't
>> have the necessary hardware so I was not able to test that at all. As
>> that is the actual bug I am still hoping someone can test it.
>
> Unfortunately, I don't have any big-endian systems either.
That probably explains why the breakage in big-endian was never noticed.
I am starting to wonder if anyone is actually doing big-endian for new
systems anymore.
Eric
next prev parent reply other threads:[~2019-05-18 15:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 2:34 [CFT][PATCH] signal/usb: Replace kill_pid_info_as_cred with kill_pid_usb_asyncio Eric W. Biederman
2019-02-08 21:57 ` Alan Stern
2019-05-18 1:38 ` Eric W. Biederman
2019-05-18 15:20 ` Alan Stern
2019-05-18 15:25 ` Eric W. Biederman [this message]
2019-05-21 12:40 ` [PATCH] " Eric W. Biederman
2019-05-21 14:02 ` Alan Stern
2019-05-21 14:47 ` Eric W. Biederman
2019-05-21 15:30 ` Alan Stern
2019-05-22 19:02 ` Alan Stern
2019-05-22 21:50 ` Eric W. Biederman
2019-05-23 18:12 ` Alan Stern
2019-05-23 20:54 ` Eric W. Biederman
2019-06-06 14:27 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sv3ss32.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).