From: "Bjørn Mork" <bjorn@mork.no>
To: "Freddy" <freddy@asix.com.tw>
Cc: "'Michael Leun'" <lkml20130126@newton.leun.net>,
<netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <louis@asix.com.tw>,
<davem@davemloft.net>, <Support@asix.com.tw>
Subject: Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver
Date: Mon, 28 Jan 2013 15:24:34 +0100 [thread overview]
Message-ID: <878v7dpeql.fsf@nemi.mork.no> (raw)
In-Reply-To: <010f01cdfd5c$768d4240$63a7c6c0$@asix.com.tw> (freddy@asix.com.tw's message of "Mon, 28 Jan 2013 21:36:20 +0800")
"Freddy" <freddy@asix.com.tw> writes:
> Bjørn, I am trying to reproduce the issue mentioned by Michael and I
> have a question about submitting this driver.
>
> Should I merge this driver into asix_devices.c and asix_common.c even
> through the usb command, tx_fixup, and rx_fixup functions are totally
> different?
This is only my personal opinion and does not count as more than that,
but I would have tried to identify as many common parts as possible in
these drivers and reuse as much code as possible instead of creating
slightly different copies. That does not mean that there shouldn't be
anything different. If the framing is completely different, then it
does of course not make any sense to share tx_fixup and rx_fixup. But
my impression from looking briefly on these drivers is that a lof of the
code is very similar. I could of course be wrong...
Please note that modifying asix_common.c in this process is perfectly OK
if that is necessary. The only requirement is that you don't break
anything that used to work.
Bjørn
next prev parent reply other threads:[~2013-01-28 14:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 2:32 [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver Freddy Xin
2013-01-23 4:15 ` David Miller
2013-01-26 23:13 ` Michael Leun
2013-01-28 9:07 ` Bjørn Mork
2013-01-28 13:36 ` Freddy
2013-01-28 14:24 ` Bjørn Mork [this message]
2013-01-28 16:42 ` Michael Leun
-- strict thread matches above, loose matches on Subject: below --
2013-03-02 10:41 [PATCH " Freddy Xin
2013-03-03 6:44 ` David Miller
2013-02-27 12:01 Freddy Xin
2013-03-01 21:15 ` David Miller
2013-02-07 13:39 [PATCH, " Freddy Xin
2013-02-07 20:02 ` Ben Hutchings
2013-02-07 20:05 ` David Miller
2013-02-08 3:41 ` Freddy
2013-02-08 10:23 ` David Laight
2013-02-08 19:23 ` David Miller
2013-02-07 4:36 Freddy Xin
2013-02-07 5:45 ` Stephen Hemminger
2013-02-07 6:45 ` Freddy
2013-02-07 5:46 ` Stephen Hemminger
2013-02-07 6:50 ` Freddy
2013-02-03 14:21 Daniel J Blueman
2013-12-04 12:48 ` Freddy
2013-01-17 9:32 Freddy Xin
2013-01-18 19:23 ` David Miller
2013-01-18 20:29 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v7dpeql.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=Support@asix.com.tw \
--cc=davem@davemloft.net \
--cc=freddy@asix.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkml20130126@newton.leun.net \
--cc=louis@asix.com.tw \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).