linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Ingo Molnar <mingo@kernel.org>
Cc: akpm@osdl.org, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, x86@kernel.org, peterz@infradead.org,
	jgross@suse.com, mgorman@techsingularity.net, richard@nod.at,
	len.brown@intel.com, bp@suse.de, boris.ostrovsky@oracle.com,
	tim.c.chen@linux.intel.com, ak@linux.intel.com, jolsa@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches
Date: Wed, 26 Oct 2016 16:34:42 +1100	[thread overview]
Message-ID: <87d1iny8p9.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20161016070406.GA4211@gmail.com>

Ingo Molnar <mingo@kernel.org> writes:
> * Michael Ellerman <mpe@ellerman.id.au> wrote:
>> @@ -564,8 +560,11 @@ void __init smp_init(void)
>>  			cpu_up(cpu);
>>  	}
>>  
>> +	num_nodes = num_online_nodes();
>> +	pr_info("smp: Brought up %d node%s, %d CPUs\n",
>> +		num_nodes, (num_nodes > 1 ? "s" : ""), num_online_cpus());
>
> No objections - but pedantry requires me to mention that while we are evolving 
> this code and changing the strings I think we should make the CPU announcement 
> CPU%s smart as well: an SMP kernel on a single CPU bootup will result in 
> num_online_cpus() == 1, right?

Yeah that makes sense. I don't often boot any single CPU systems, but I
tested with maxcpus=1 and it does look nicer:

    smp: Brought up 2 nodes, 1 CPU


Will send a v2.

cheers

      reply	other threads:[~2016-10-26  5:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13  8:55 [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches Michael Ellerman
2016-10-13  8:55 ` [PATCH 2/2] kernel/smp: Tell the user we're bringing up secondary CPUs Michael Ellerman
2016-10-14 11:54 ` [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches Borislav Petkov
2016-10-26  5:32   ` Michael Ellerman
2016-10-16  7:04 ` Ingo Molnar
2016-10-26  5:34   ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1iny8p9.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=ak@linux.intel.com \
    --cc=akpm@osdl.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=jolsa@redhat.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=richard@nod.at \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).