From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net, libc-alpha@sourceware.org,
qemu-devel@nongnu.org, ericvh@gmail.com, lucho@ionkov.net,
hpa@zytor.com, arnd@arndb.de
Subject: Re: d_off field in struct dirent and 32-on-64 emulation
Date: Fri, 28 Dec 2018 13:01:43 +0100 [thread overview]
Message-ID: <87ftuhvp08.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <87k1jtvp8u.fsf@mid.deneb.enyo.de> (Florian Weimer's message of "Fri, 28 Dec 2018 12:56:33 +0100")
* Florian Weimer:
> * Adhemerval Zanella:
>
>> On 27/12/2018 16:09, Florian Weimer wrote:
>>> * Adhemerval Zanella:
>>>
>>>> Also for glibc standpoint, although reverting it back to use getdents
>>>> syscall for non-LFS mode might fix this issue for architectures that
>>>> provides non-LFS getdents syscall it won't be a fix for architectures
>>>> that still provides off_t different than off64_t *and* only provides
>>>> getdents64 syscall.
>>>>
>>>> Currently we only have nios2 and csky (unfortunately). But since generic
>>>> definition for off_t and off64_t still assumes non-LFS support, all new
>>>> 32-bits ports potentially might carry the issue.
>>>
>>> For csky, we could still change the type of the non-standard d_off
>>> field to long long int. This way, only telldir would have to fail
>>> when truncation is necessary, as mentioned below:
>>
>> I think it makes no sense to continue making non-LFS as default for
>> newer 32 bits ports, the support will be emulated with LFS syscalls.
>
> Sorry, I don't see how this matters. seekdir and telldir are NOT
> affected by LFS.
Ah, right. If struct dirent is 64-bit only, then the d_off member
will be 64 bits as well. But it is unclear whether you can use that
with lseek (probably yes, in its 64-bit variant), and it's unlikely
it's going to work with seekdir because of the POSIX-required long int
type.
next prev parent reply other threads:[~2018-12-28 12:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 17:18 d_off field in struct dirent and 32-on-64 emulation Florian Weimer
2018-12-27 17:41 ` [Qemu-devel] " Peter Maydell
2018-12-28 0:23 ` Andreas Dilger
2018-12-28 11:18 ` Peter Maydell
2018-12-28 23:16 ` Andreas Dilger
2018-12-29 0:12 ` Peter Maydell
2018-12-29 1:54 ` Matthew Wilcox
2018-12-29 16:49 ` Andy Lutomirski
2018-12-30 13:59 ` Peter Maydell
2018-12-29 2:11 ` Theodore Y. Ts'o
2018-12-29 2:37 ` Dominique Martinet
2018-12-29 3:14 ` Theodore Y. Ts'o
2018-12-29 4:04 ` [V9fs-developer] " Dominique Martinet
[not found] ` <C65D3222-723F-4C0B-AF02-38488C302E84@amacapital.net>
2018-12-27 17:56 ` Florian Weimer
2018-12-27 17:58 ` Adhemerval Zanella
2018-12-27 18:09 ` Florian Weimer
2018-12-28 11:53 ` Adhemerval Zanella
2018-12-28 11:56 ` Florian Weimer
2018-12-28 12:01 ` Florian Weimer [this message]
2018-12-28 12:21 ` Adhemerval Zanella
2018-12-31 17:03 ` Joseph Myers
2019-01-02 13:16 ` Adhemerval Zanella
2018-12-28 2:23 ` Dmitry V. Levin
2018-12-28 7:38 ` Florian Weimer
2018-12-28 15:26 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftuhvp08.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adhemerval.zanella@linaro.org \
--cc=arnd@arndb.de \
--cc=ericvh@gmail.com \
--cc=hpa@zytor.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=qemu-devel@nongnu.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).