From: "Aurélien Aptel" <aaptel@suse.com>
To: Colin King <colin.king@canonical.com>,
samba-technical@lists.samba.org, Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: remove redundant assignment to variable rc
Date: Wed, 31 Jul 2019 12:09:31 +0200 [thread overview]
Message-ID: <87r266seg4.fsf@suse.com> (raw)
In-Reply-To: <20190731090526.27245-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> writes:
> Variable rc is being initialized with a value that is never read
> and rc is being re-assigned a little later on. The assignment is
> redundant and hence can be removed.
I think I would actually rather have rc set to an error by default than
uninitialized. Just my personal opinion.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2019-07-31 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 9:05 [PATCH] cifs: remove redundant assignment to variable rc Colin King
2019-07-31 10:09 ` Aurélien Aptel [this message]
2019-07-31 12:28 ` Dan Carpenter
2019-07-31 15:34 ` Aurélien Aptel
2019-07-31 15:54 ` Colin Ian King
2019-08-01 17:00 ` Steve French
2019-08-01 8:03 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r266seg4.fsf@suse.com \
--to=aaptel@suse.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).