From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31EDAC433E0 for ; Fri, 22 May 2020 19:54:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00F0C2070A for ; Fri, 22 May 2020 19:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730965AbgEVTyk (ORCPT ); Fri, 22 May 2020 15:54:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730893AbgEVTyj (ORCPT ); Fri, 22 May 2020 15:54:39 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A40F6C061A0E for ; Fri, 22 May 2020 12:54:39 -0700 (PDT) Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jcDkB-0003sk-Hq; Fri, 22 May 2020 21:54:11 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 06578100F17; Fri, 22 May 2020 21:54:11 +0200 (CEST) From: Thomas Gleixner To: Josh Poimboeuf , Boris Ostrovsky Cc: Andy Lutomirski , LKML , X86 ML , "Paul E. McKenney" , Alexandre Chartre , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , Steven Rostedt , Joel Fernandes , Juergen Gross , Brian Gerst , Mathieu Desnoyers , Will Deacon , Tom Lendacky , Wei Liu , Michael Kelley , Jason Chen CJ , Zhao Yakui , "Peter Zijlstra \(Intel\)" Subject: Re: [patch V6 19/37] x86/irq: Convey vector as argument and not in ptregs In-Reply-To: <20200522192615.5asnbnanfdiofaj6@treble> References: <87sgfttobg.fsf@nanos.tec.linutronix.de> <20200522192615.5asnbnanfdiofaj6@treble> Date: Fri, 22 May 2020 21:54:10 +0200 Message-ID: <87sgfrrbj1.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Josh Poimboeuf writes: > On Fri, May 22, 2020 at 02:48:53PM -0400, Boris Ostrovsky wrote: >> > Yes. They just make objtool very unhappy: >> > >> > arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0xfd0: special: >> > can't find orig instruction >> > >> > Peter suggested to use: >> > >> > .pos = . >> > .byte.. >> > jmp >> > .nops (pos + 8) - . >> >> >> Unfortunately this (.nops directive) only works for newer assemblers >> (2.31, per >> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob_plain;f=gas/NEWS;h=9a3f352108e439754688e19e63a6235b38801182;hb=5eb617a71463fa6810cd14f57adfe7a1efc93a96) >> >> >> I have 2.27 and things don't go well. > > A single nop should be fine, since gas will complain if it tries to move > the IP backwards. Yes. That's what I posted in the V9 thread :) > (Also I'd vote for normal indentation instead of the "assembler magic > at 4 spaces" thing.) let me fix that