From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Oleg Nesterov <oleg@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Ben Segall <bsegall@google.com>, Borislav Petkov <bp@alien8.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] signal/x86: Delay calling signals in atomic
Date: Mon, 28 Mar 2022 09:48:48 -0500 [thread overview]
Message-ID: <87v8vyuo8f.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <8735j2xigt.fsf@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Mon, 28 Mar 2022 09:25:06 -0500")
"Eric W. Biederman" <ebiederm@xmission.com> writes:
>> diff --git a/kernel/signal.c b/kernel/signal.c
>> index 9b04631acde8f..cb2b28c17c0a5 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -1327,6 +1327,34 @@ force_sig_info_to_task(struct kernel_siginfo *info, struct task_struct *t,
>> struct k_sigaction *action;
>> int sig = info->si_signo;
^^^^^^^^^^^^^^^^^^^^^^^^^
See info->si_signo is unconditionally dereferenced.
>>
>> + /*
>> + * On some archs, PREEMPT_RT has to delay sending a signal from a trap
>> + * since it can not enable preemption, and the signal code's spin_locks
>> + * turn into mutexes. Instead, it must set TIF_NOTIFY_RESUME which will
>> + * send the signal on exit of the trap.
>> + */
>> +#ifdef ARCH_RT_DELAYS_SIGNAL_SEND
>> + if (in_atomic()) {
>> + struct task_struct *t = current;
>> +
>> + if (WARN_ON_ONCE(t->forced_info.si_signo))
>> + return 0;
>> +
>> + if (is_si_special(info)) {
^^^^^^^^^^^^^^^^^^^
This tests to see if info is either 0 or 1 cased to as "kernel_siginfo *"
Which is a long way of saying this code already guarantees that
is_si_special is guaranteed to be false so most of this code is
completely unnecessary.
>> + WARN_ON_ONCE(info != SEND_SIG_PRIV);
>> + t->forced_info.si_signo = info->si_signo;
>> + t->forced_info.si_errno = 0;
>> + t->forced_info.si_code = SI_KERNEL;
>> + t->forced_info.si_pid = 0;
>> + t->forced_info.si_uid = 0;
>> + } else {
>> + t->forced_info = *info;
>> + }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
All of that can just be:
copy_siginfo(&t->force_info, info);
Using a structure copy here that gcc is allowed to not copy bytes in the
padding is wrong in that it allows an information leak to userspace.
>> + set_tsk_thread_flag(t, TIF_NOTIFY_RESUME);
>> + return 0;
>> + }
>> +#endif
>> spin_lock_irqsave(&t->sighand->siglock, flags);
>> action = &t->sighand->action[sig-1];
>> ignored = action->sa.sa_handler == SIG_IGN;
Eric
next prev parent reply other threads:[~2022-03-28 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 20:19 [PATCH] signal/x86: Delay calling signals in atomic Sebastian Andrzej Siewior
2022-03-28 14:25 ` Eric W. Biederman
2022-03-28 14:41 ` Eric W. Biederman
2022-03-28 16:32 ` Sebastian Andrzej Siewior
2022-03-28 14:48 ` Eric W. Biederman [this message]
2022-03-28 16:17 ` Sebastian Andrzej Siewior
2022-03-28 22:07 ` Eric W. Biederman
2022-03-29 9:31 ` Sebastian Andrzej Siewior
2022-03-30 18:10 ` Eric W. Biederman
2022-04-01 11:45 ` Sebastian Andrzej Siewior
2022-04-04 14:29 ` Eric W. Biederman
2022-03-28 16:28 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8vyuo8f.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=hpa@zytor.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).