From: Michael Ellerman <mpe@ellerman.id.au>
To: Thorsten Leemhuis <regressions@leemhuis.info>,
Dave Airlie <airlied@redhat.com>,
DRI <dri-devel@lists.freedesktop.org>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Christian König" <christian.koenig@amd.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Next Mailing List" <linux-next@vger.kernel.org>,
"Linux kernel regressions list" <regressions@lists.linux.dev>,
"Justin Forbes" <jforbes@redhat.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: Re: build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree)
Date: Thu, 27 Apr 2023 09:27:15 +1000 [thread overview]
Message-ID: <87y1mexm0c.fsf@mail.concordia> (raw)
In-Reply-To: <872f3ba1-1771-2ef4-1353-4cadd92eb5e1@leemhuis.info>
Thorsten Leemhuis <regressions@leemhuis.info> writes:
> Lo!
>
> Sometimes the regression tracker runs into regressions himself... :-D
>
> On 11.04.23 08:47, Stephen Rothwell wrote:
>>
>> After merging the drm tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>>
>> drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope
>> 73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER];
>> | ^~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/ttm/ttm_pool.c:74:29: error: variably modified 'global_uncached' at file scope
>> 74 | static struct ttm_pool_type global_uncached[TTM_DIM_ORDER];
>> | ^~~~~~~~~~~~~~~
>> drivers/gpu/drm/ttm/ttm_pool.c:76:29: error: variably modified 'global_dma32_write_combined' at file scope
>> 76 | static struct ttm_pool_type global_dma32_write_combined[TTM_DIM_ORDER];
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/ttm/ttm_pool.c:77:29: error: variably modified 'global_dma32_uncached' at file scope
>> 77 | static struct ttm_pool_type global_dma32_uncached[TTM_DIM_ORDER];
>> | ^~~~~~~~~~~~~~~~~~~~~
>>
>> Caused by commit
>>
>> 322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages")
>>
>> PMD_SHIFT is not necessarily a constant on ppc (see
>> arch/powerpc/include/asm/book3s/64/pgtable.h).
>>
>> I have reverted that commit for today.
>
> Did anyone look into this?
Christian sent a revert:
56e51681246e ("drm/ttm: revert "Reduce the number of used allocation orders for TTM pages"")
Which has been in linux-next since the 21st. But I guess it missed being
in the initial DRM pull request.
See also other thread:
https://lore.kernel.org/all/ZEljCgVFnDl%2FC+l3@debian/
Where Christian says the revert is "on the way" to Linus.
cheers
prev parent reply other threads:[~2023-04-26 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 6:47 linux-next: build failure after merge of the drm tree Stephen Rothwell
2023-04-26 5:59 ` build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree) Thorsten Leemhuis
2023-04-26 23:27 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1mexm0c.fsf@mail.concordia \
--to=mpe@ellerman.id.au \
--cc=airlied@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jforbes@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=sfr@canb.auug.org.au \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).