From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Wen Yang <wenyang@linux.alibaba.com>
Cc: zhiche.yy@alibaba-inc.com, xlpang@linux.alibaba.com,
Wen Yang <wenyang@linux.alibaba.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com
Subject: Re: [PATCH] intel_th: avoid double free in error flow
Date: Wed, 20 Nov 2019 15:06:26 +0200 [thread overview]
Message-ID: <87y2wad7e5.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20191119173447.2454-1-wenyang@linux.alibaba.com>
Wen Yang <wenyang@linux.alibaba.com> writes:
> There is a possible double free issue in intel_th_subdevice_alloc:
>
> 651 err = intel_th_device_add_resources(thdev, res, subdev->nres);
> 652 if (err) {
> 653 put_device(&thdev->dev);
> 654 goto fail_put_device; ---> freed
> 655 }
> ...
> 687 fail_put_device:
> 688 put_device(&thdev->dev); ---> double freed
> 689
>
> This patch fix it by removing the unnecessary put_device().
Unnecessary is a too generous term here.
> Fixes: a753bfcfdb1f ("intel_th: Make the switch allocate its subdevices")
> Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-kernel@vger.kernel.org
Cc: stable@ is missing.
> ---
> drivers/hwtracing/intel_th/core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
> index d5c1821..98d195c 100644
> --- a/drivers/hwtracing/intel_th/core.c
> +++ b/drivers/hwtracing/intel_th/core.c
> @@ -649,10 +649,8 @@ static inline void intel_th_request_hub_module_flush(struct intel_th *th)
> }
>
> err = intel_th_device_add_resources(thdev, res, subdev->nres);
> - if (err) {
> - put_device(&thdev->dev);
> + if (err)
> goto fail_put_device;
> - }
What about the second instance of the same problem a few lines lower?
Thanks,
--
Alex
next prev parent reply other threads:[~2019-11-20 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 17:34 [PATCH] intel_th: avoid double free in error flow Wen Yang
2019-11-20 13:06 ` Alexander Shishkin [this message]
2019-11-20 13:31 ` Wen Yang
2019-11-20 13:38 ` Alexander Shishkin
2019-11-20 13:46 ` Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2wad7e5.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wenyang@linux.alibaba.com \
--cc=xlpang@linux.alibaba.com \
--cc=zhiche.yy@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).