From: Jonathan Corbet <corbet@lwn.net>
To: "Yuji Ishikawa" <yuji2.ishikawa@toshiba.co.jp>,
"Rob Herring" <robh+dt@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
yuji2.ishikawa@toshiba.co.jp
Subject: Re: [PATCH v2 5/5] Documentation: driver-api: visconti: add a description of DNN driver.
Date: Fri, 22 Jul 2022 07:32:58 -0600 [thread overview]
Message-ID: <87zgh1jmr9.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220722082858.17880-6-yuji2.ishikawa@toshiba.co.jp>
Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> writes:
No changelog?
> Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
> ---
> v1 -> v2:
> - newly added documents
> ---
> Documentation/driver-api/visconti/common.rst | 115 ++++++
> Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++++++++
> 2 files changed, 509 insertions(+)
> create mode 100644 Documentation/driver-api/visconti/common.rst
> create mode 100644 Documentation/driver-api/visconti/dnn.rst
Two overall comments:
- You've added new RST files without adding them to index.rst; that
will keep them from being part of the kernel docs build and will add
new warnings.
- Please avoid the use of flat-table and just use regular RST
ascii-art tables. Otherwise the result is nearly unreadable in the
plain-test format.
Thanks,
jon
next prev parent reply other threads:[~2022-07-22 13:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 8:28 [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver Yuji Ishikawa
2022-07-22 8:28 ` [PATCH v2 1/5] dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing accelerator bindings Yuji Ishikawa
2022-07-22 8:28 ` [PATCH v2 2/5] soc: visconti: Add Toshiba Visconti image processing accelerator common source Yuji Ishikawa
2022-07-25 12:46 ` Greg KH
2022-07-26 7:02 ` yuji2.ishikawa
2022-07-22 8:28 ` [PATCH v2 3/5] soc: visconti: Add Toshiba Visconti DNN image processing accelerator Yuji Ishikawa
2022-07-25 12:48 ` Greg KH
2022-07-26 6:10 ` yuji2.ishikawa
2022-07-25 12:50 ` Greg KH
2022-07-26 6:10 ` yuji2.ishikawa
2022-07-26 15:15 ` Greg KH
2022-07-22 8:28 ` [PATCH v2 4/5] MAINTAINERS: Add entries for " Yuji Ishikawa
2022-07-25 12:47 ` Greg KH
2022-07-26 6:10 ` yuji2.ishikawa
2022-07-28 8:46 ` Greg KH
2022-07-22 8:28 ` [PATCH v2 5/5] Documentation: driver-api: visconti: add a description of DNN driver Yuji Ishikawa
2022-07-22 13:32 ` Jonathan Corbet [this message]
2022-07-26 6:10 ` yuji2.ishikawa
2022-07-25 12:46 ` [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver Greg KH
2022-07-26 6:09 ` yuji2.ishikawa
2022-07-28 8:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgh1jmr9.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).