From: Michael Ellerman <mpe@ellerman.id.au>
To: Mark Brown <broonie@kernel.org>, Rob Herring <rob.herring@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
kirill@shutemov.name, Linus Walleij <linus.walleij@linaro.org>,
boris.brezillon@bootlin.com,
Catalin Marinas <catalin.marinas@arm.com>,
Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>,
jacek.anaszewski@gmail.com, axboe@kernel.dk,
Ulf Hansson <ulf.hansson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Git pull ack emails..
Date: Thu, 01 Nov 2018 21:18:28 +1100 [thread overview]
Message-ID: <87zhutdrt7.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181026211504.GG27137@sirena.org.uk>
Mark Brown <broonie@kernel.org> writes:
> On Fri, Oct 26, 2018 at 12:36:14PM -0500, Rob Herring wrote:
>> On Thu, Oct 25, 2018 at 9:14 AM Linus Torvalds
>> <torvalds@linux-foundation.org> wrote:
>
>> > Are there other situations where you might want to track something
>> > _outside_ of a pull request? Maybe. I can't really think of a lot of
>> > them, though. Patches etc don't have commit ID's to track, but it
>
> patchwork gives them IDs and lets you do lookups using them, that's what
> I'm doing. You can get the ID from a git commit by piping the output of
> git show into parser.py from the patchwork source, it works a lot of the
> time but things like editing the commit message will break it (this is a
> theme with my scripting around the mail stuff...).
>
>> submissions. For example, with Greg and Mark B you can expect an
>> automated replies. Mark's reply gets threaded with the original, but
>> Greg's do not. For networking, you may or may not get a manual reply,
>
> Mine *mostly* gets threaded, it's relying on being able to talk to
> patchwork to figure out the message ID at the minute so if the patchwork
> lookup fails for whatever reason it'll just use on what's in the commit
> for the CC list and not thread. That isn't ideal, especially when I'm
> travelling and my network connection isn't the best, I keep meaning to
> try to figure out a better way which would probably be based on git
> notes as discussed earlier.
Yeah I use git notes for this.
When I apply a patch I record the patchwork id in a git note, I have a
custom hacked pwclient that does it automatically. I also download the
full mbox from patchwork and stash it in .git/patchwork/<patch id>.
Then I have everything I need to generate a properly threaded reply to
the original mail.
The git notes work well, if you add the following to your .git/config:
[notes]
rewriteRef = refs/notes/*
displayRef = refs/notes/*
Then all notes are copied when you rewrite a commit (rebase), and also
displayed by eg. git show.
Every now and then if you do extensive rebasing/splitting you get
commits with the wrong or no patchwork ids. But that's pretty rare and
not that hard to fixup when it happens.
There's a slightly sanitised version of some of my scripts here:
https://github.com/mpe/patchwork-scripts
cheers
next prev parent reply other threads:[~2018-11-01 10:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 8:41 Git pull ack emails Linus Torvalds
2018-10-23 8:53 ` Linus Walleij
2018-10-23 9:10 ` Linus Torvalds
2018-10-23 9:35 ` Kirill A. Shutemov
2018-10-23 9:45 ` Mark Brown
2018-10-23 9:46 ` Linus Torvalds
2018-10-23 20:04 ` Konstantin Ryabitsev
2018-10-25 14:13 ` Linus Torvalds
2018-10-26 17:36 ` Rob Herring
2018-10-26 21:15 ` Mark Brown
2018-11-01 10:18 ` Michael Ellerman [this message]
2018-11-07 10:41 ` Boris Brezillon
2018-11-07 23:56 ` Michael Ellerman
2018-10-31 14:27 ` Konstantin Ryabitsev
2018-10-31 18:34 ` Linus Torvalds
2018-10-23 9:02 ` Willy Tarreau
2018-10-23 9:15 ` Linus Torvalds
2018-10-23 9:23 ` Takashi Iwai
2018-10-23 9:15 ` Ingo Molnar
2018-10-23 9:17 ` Boris Brezillon
2018-10-23 9:47 ` Mark Brown
2018-10-23 9:19 ` Mark Brown
2018-10-23 9:25 ` Greg KH
2018-10-23 9:51 ` James Morris
2018-10-23 9:56 ` Jens Axboe
2018-10-23 12:13 ` Ulf Hansson
2018-10-23 20:41 ` Jacek Anaszewski
2018-10-23 20:01 ` Olof Johansson
2018-10-24 22:21 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhutdrt7.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=axboe@kernel.dk \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jacek.anaszewski@gmail.com \
--cc=kirill@shutemov.name \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rob.herring@linaro.org \
--cc=torvalds@linux-foundation.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).