From: Shuah Khan <shuah@kernel.org>
To: David Laight <David.Laight@ACULAB.COM>,
"'Shuah Khan'" <shuahkh@osg.samsung.com>,
"bamvor.zhangjian@linaro.org" <bamvor.zhangjian@linaro.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"paulus@samba.org" <paulus@samba.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"dvhart@infradead.org" <dvhart@infradead.org>
Cc: "linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"dsafonov@virtuozzo.com" <dsafonov@virtuozzo.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"emilio.lopez@collabora.co.uk" <emilio.lopez@collabora.co.uk>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"luto@kernel.org" <luto@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"mingo@kernel.org" <mingo@kernel.org>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean
Date: Mon, 24 Apr 2017 13:46:23 -0600 [thread overview]
Message-ID: <8845c13f-eaeb-86a1-1ac8-d7c52e934ef4@kernel.org> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DCFFD98E2@AcuExch.aculab.com>
On 04/24/2017 09:45 AM, David Laight wrote:
> From: Shuah Khan
>> Sent: 22 April 2017 00:15
>> Define CLEAN macro to allow Makefiles to override common clean target
>> in lib.mk. This will help fix the following failures:
>>
>> warning: overriding recipe for target 'clean'
>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> tools/testing/selftests/lib.mk | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
>> index 775c589..959273c 100644
>> --- a/tools/testing/selftests/lib.mk
>> +++ b/tools/testing/selftests/lib.mk
>> @@ -51,8 +51,12 @@ endef
>> emit_tests:
>> $(EMIT_TESTS)
>>
>> -clean:
>> +define CLEAN
>> $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN)
>> +endef
>> +
>> +clean:
>> + $(CLEAN)
>
> If might be easier to do something like:
>
> ifneq($(NO_CLEAN),y)
> clean:
> $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN)
> endif
>
> David
>
I am not sure that it is easier. Defining a macro would work well
in this case to override and also works well with what we are doing
for other overrides we already have such as EMIT_TESTS.
thanks,
-- Shuah
next prev parent reply other threads:[~2017-04-24 19:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 23:14 [PATCH 0/8] Fix clean target warnings Shuah Khan
2017-04-21 23:14 ` [PATCH 1/8] selftests: splice: fix clean target to not remove default_file_splice_read.sh Shuah Khan
2017-04-21 23:14 ` [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Shuah Khan
2017-04-22 5:38 ` Michael Ellerman
2017-04-25 13:36 ` Shuah Khan
2017-04-26 10:55 ` Michael Ellerman
2017-04-24 15:45 ` David Laight
2017-04-24 19:46 ` Shuah Khan [this message]
2017-04-21 23:14 ` [PATCH 3/8] selftests: futex: override clean in lib.mk to fix warnings Shuah Khan
2017-04-27 21:54 ` Darren Hart
2017-04-27 21:57 ` Shuah Khan
2017-04-21 23:14 ` [PATCH 4/8] selftests: gpio: " Shuah Khan
2017-04-22 5:40 ` Michael Ellerman
2017-04-25 15:02 ` Shuah Khan
2017-04-21 23:14 ` [PATCH 5/8] selftests: powerpc: " Shuah Khan
2017-04-21 23:14 ` [PATCH 6/8] selftests: splice: " Shuah Khan
2017-04-22 5:40 ` Michael Ellerman
2017-04-25 15:03 ` Shuah Khan
2017-04-21 23:14 ` [PATCH 7/8] selftests: sync: " Shuah Khan
2017-04-22 5:41 ` Michael Ellerman
2017-04-25 15:03 ` Shuah Khan
2017-04-21 23:14 ` [PATCH 8/8] selftests: x86: " Shuah Khan
2017-04-22 5:41 ` Michael Ellerman
2017-04-24 15:57 ` David Laight
2017-04-24 19:48 ` Shuah Khan
2017-04-25 15:03 ` Shuah Khan
2017-04-27 22:02 ` [PATCH 0/8] Fix clean target warnings Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8845c13f-eaeb-86a1-1ac8-d7c52e934ef4@kernel.org \
--to=shuah@kernel.org \
--cc=David.Laight@ACULAB.COM \
--cc=bamvor.zhangjian@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@linux.intel.com \
--cc=dsafonov@virtuozzo.com \
--cc=dvhart@infradead.org \
--cc=emilio.lopez@collabora.co.uk \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rkrcmar@redhat.com \
--cc=shuahkh@osg.samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).