From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Russell King, ARM Linux" <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Kees Cook <keescook@chromium.org>,
William Cohen <wcohen@redhat.com>,
stable <stable@vger.kernel.org>,
Laura Abbott <labbott@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
lttng <lttng@reliableembeddedsystems.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: BUG: optimized kprobes illegal instructions in v4.19 stable kernels
Date: Fri, 22 Feb 2019 15:18:46 -0500 (EST) [thread overview]
Message-ID: <886010660.5183.1550866726676.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20190222082924.GA16734@kroah.com>
----- On Feb 22, 2019, at 3:29 AM, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
> On Fri, Feb 22, 2019 at 07:25:50AM +0100, Greg Kroah-Hartman wrote:
>> On Thu, Feb 21, 2019 at 07:17:11PM -0500, Mathieu Desnoyers wrote:
>> > ----- On Feb 21, 2019, at 7:10 PM, Russell King, ARM Linux linux@armlinux.org.uk
>> > wrote:
>> >
>> > > On Thu, Feb 21, 2019 at 03:02:57PM -0500, Mathieu Desnoyers wrote:
>> > >> Hi Arnd, Russell, Linus,
>> > >>
>> > >> Can we ensure the arm32 kprobes fix I submitted gets upstream before 5.0 final ?
>> > >> It takes care of an illegal instruction issue with optimized kprobes on arm32.
>> > >>
>> > >> Here is the current state of default kprobes configuration on arm32:
>> > >> using them will trigger illegal instruction OOPS on v5.0-rc7, 4.19.24,
>> > >> v4.14.102.
>> > >>
>> > >> My fix is in "accepted" state in the arm patch tracking system:
>> > >>
>> > >> https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8834/1
>> > >>
>> > >> Should I send it directly to Linus as well ?
>> > >
>> > > Accepted means it's in my tree pending to be sent to Linus. It should
>> > > now be in mainline. Have you checked?
>> >
>> > Hrm, why did I not see it earlier today... it's embarrassing.
>> >
>> > It's there indeed, all is good!
>> >
>> > Greg, you should be able to pick it into the stable kernels now.
>>
>> What is the git commit id of it?
>
> Oh nevermind, I see it. I'll queue it up for the next round of kernel
> releases after this one.
Sorry about late reply, it's indeed
commit 0ac569bf6a79 ("ARM: 8834/1: Fix: kprobes: optimized kprobes illegal instruction")
upstream.
Thanks!
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2019-02-22 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 19:15 BUG: optimized kprobes illegal instructions in v4.19 stable kernels Mathieu Desnoyers
2019-02-05 15:06 ` Kees Cook
2019-02-06 4:41 ` Masami Hiramatsu
2019-02-18 12:26 ` Greg KH
2019-02-18 14:11 ` Masami Hiramatsu
2019-02-18 14:55 ` Mathieu Desnoyers
2019-02-21 20:02 ` Mathieu Desnoyers
2019-02-22 0:10 ` Russell King - ARM Linux admin
2019-02-22 0:17 ` Mathieu Desnoyers
2019-02-22 6:25 ` Greg Kroah-Hartman
2019-02-22 8:29 ` Greg Kroah-Hartman
2019-02-22 20:18 ` Mathieu Desnoyers [this message]
2019-02-06 11:48 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=886010660.5183.1550866726676.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lttng@reliableembeddedsystems.com \
--cc=mhiramat@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wcohen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).