From: Liu Ying <victor.liu@nxp.com>
To: Robert Foss <robert.foss@linaro.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-media <linux-media@vger.kernel.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
linux-imx@nxp.com, Mauro Carvalho Chehab <mchehab@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
kishon@ti.com, Vinod Koul <vkoul@kernel.org>,
lee.jones@linaro.org
Subject: Re: [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp
Date: Wed, 31 Mar 2021 14:25:57 +0800 [thread overview]
Message-ID: <8905aad5ba0a37d1c889cfe612b785817d0f1193.camel@nxp.com> (raw)
In-Reply-To: <CAG3jFytpciiAGKnUyb6H-GoLYks9RRxHm3cRaH_PN_zhxZDUjQ@mail.gmail.com>
On Tue, 2021-03-30 at 11:54 +0200, Robert Foss wrote:
> Hey Liu,
>
> checkpatch --strict lists some nit and a warning. With those fixed
> feel free to add my r-b.
>
> On Wed, 17 Mar 2021 at 04:57, Liu Ying <victor.liu@nxp.com> wrote:
> > This patch adds a drm bridge driver for i.MX8qxp LVDS display bridge(LDB)
> > which is officially named as pixel mapper. The LDB has two channels.
> > Each of them supports up to 24bpp parallel input color format and can map
> > the input to VESA or JEIDA standards. The two channels cannot be used
> > simultaneously, that is to say, the user should pick one of them to use.
> > Two LDB channels from two LDB instances can work together in LDB split
> > mode to support a dual link LVDS display. The channel indexes have to be
> > different. Channel0 outputs odd pixels and channel1 outputs even pixels.
> > This patch supports the LDB single mode and split mode.
> >
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > Note that this patch depends on the patch 'phy: Add LVDS configuration options',
> > which has already been sent with the following series to add Mixel combo PHY
> > found in i.MX8qxp:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Farm-kernel%2Fmsg879957.html&data=04%7C01%7Cvictor.liu%40nxp.com%7C7c4f1092633c4687fb3108d8f361ddfd%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637526948949839014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=iNr6RU0xrhcW8epwIPPJDpayjWxfmWsSjCju3XIcmPM%3D&reserved=0
> >
> > v5->v6:
> > * No change.
> >
> > v4->v5:
> > * Link with the imx-ldb-helper object. (Robert)
> > * Correspondingly, rename 'imx8qxp-ldb.c' to 'imx8qxp-ldb-drv.c'.
> >
> > v3->v4:
> > * No change.
> >
> > v2->v3:
> > * No change.
> >
> > v1->v2:
> > * Drop unnecessary DT validation.
> > * Use of_graph_get_endpoint_by_regs() and of_graph_get_remote_endpoint() to
> > get the input remote endpoint in imx8qxp_ldb_set_di_id().
> > * Avoid using companion_port OF node after putting it in
> > imx8qxp_ldb_parse_dt_companion().
> > * Mention i.MX8qxp LDB official name 'pixel mapper' in the bridge driver
> > and Kconfig help message.
> >
> > drivers/gpu/drm/bridge/imx/Kconfig | 9 +
> > drivers/gpu/drm/bridge/imx/Makefile | 3 +
> > drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c | 720 +++++++++++++++++++++++++++
> > 3 files changed, 732 insertions(+)
> > create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c
> >
[...]
> > +
> > +static int imx8qxp_ldb_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev = &pdev->dev;
> > + struct imx8qxp_ldb *imx8qxp_ldb;
> > + struct imx8qxp_ldb_channel *imx8qxp_ldb_ch;
> > + struct ldb *ldb;
> > + struct ldb_channel *ldb_ch;
> > + int ret, i;
> > +
> > + imx8qxp_ldb = devm_kzalloc(dev, sizeof(*imx8qxp_ldb), GFP_KERNEL);
> > + if (!imx8qxp_ldb)
> > + return -ENOMEM;
> > +
> > + imx8qxp_ldb->clk_pixel = devm_clk_get(dev, "pixel");
> > + if (IS_ERR(imx8qxp_ldb->clk_pixel)) {
> > + ret = PTR_ERR(imx8qxp_ldb->clk_pixel);
> > + if (ret != -EPROBE_DEFER)
> > + DRM_DEV_ERROR(dev,
> > + "failed to get pixel clock: %d\n", ret);
> > + return ret;
> > + }
> > +
> > + imx8qxp_ldb->clk_bypass = devm_clk_get(dev, "bypass");
> > + if (IS_ERR(imx8qxp_ldb->clk_bypass)) {
> > + ret = PTR_ERR(imx8qxp_ldb->clk_bypass);
> > + if (ret != -EPROBE_DEFER)
> > + DRM_DEV_ERROR(dev,
> > + "failed to get bypass clock: %d\n", ret);
> > + return ret;
> > + }
> > +
> > + imx8qxp_ldb->dev = dev;
> > +
> > + ldb = &imx8qxp_ldb->base;
> > + ldb->dev = dev;
> > + ldb->ctrl_reg = 0xe0;
> > +
> > + for (i = 0; i < MAX_LDB_CHAN_NUM; i++)
> > + ldb->channel[i] = &imx8qxp_ldb->channel[i].base;
> > +
> > + ret = ldb_init_helper(ldb);
> > + if (ret)
> > + return ret;
> > +
> > + if (ldb->available_ch_cnt == 0) {
> > + DRM_DEV_DEBUG_DRIVER(dev, "no available channel\n");
> > + return 0;
> > + } else if (ldb->available_ch_cnt > 1) {
> > + DRM_DEV_ERROR(dev, "invalid available channel number(%u)\n",
> > + ldb->available_ch_cnt);
> > + return -ENOTSUPP;
> > + }
>
> WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
> #683: FILE: drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c:625:
> + return -ENOTSUPP;
>
> Maybe -EINVAL is a better return value.
Will use -EINVAL in the next version.
Liu Ying
next prev parent reply other threads:[~2021-03-31 6:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 3:42 [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs Liu Ying
2021-03-17 3:42 ` [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner Liu Ying
2021-03-23 0:23 ` Marcel Ziswiler
2021-03-23 3:00 ` Liu Ying
2021-03-17 3:42 ` [PATCH v6 02/14] media: docs: " Liu Ying
2021-03-17 3:42 ` [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding Liu Ying
2021-03-23 0:34 ` Marcel Ziswiler
2021-03-23 3:29 ` Liu Ying
2021-03-17 3:42 ` [PATCH v6 04/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support Liu Ying
2021-03-17 3:42 ` [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding Liu Ying
2021-03-23 0:38 ` Marcel Ziswiler
2021-03-23 3:42 ` Liu Ying
2021-03-17 3:42 ` [PATCH v6 06/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support Liu Ying
2021-03-17 3:42 ` [PATCH v6 07/14] dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding Liu Ying
2021-03-23 22:33 ` Rob Herring
2021-03-17 3:42 ` [PATCH v6 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding Liu Ying
2021-03-17 3:42 ` [PATCH v6 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support Liu Ying
2021-03-30 9:42 ` Robert Foss
2021-03-31 6:18 ` Liu Ying
2021-03-17 3:42 ` [PATCH v6 10/14] drm/bridge: imx: Add LDB driver helper support Liu Ying
2021-03-30 9:46 ` Robert Foss
2021-03-31 6:20 ` Liu Ying
2021-03-17 3:42 ` [PATCH v6 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding Liu Ying
2021-03-17 3:42 ` [PATCH v6 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp Liu Ying
2021-03-20 2:32 ` kernel test robot
2021-03-30 9:54 ` Robert Foss
2021-03-31 6:25 ` Liu Ying [this message]
2021-03-30 9:59 ` Robert Foss
2021-03-31 6:23 ` Liu Ying
2021-03-17 3:42 ` [PATCH v6 13/14] drm/bridge: imx: Add LDB support for i.MX8qm Liu Ying
2021-03-20 9:56 ` kernel test robot
2021-03-30 10:05 ` Robert Foss
2021-03-31 6:39 ` Liu Ying
2021-03-31 12:39 ` Robert Foss
2021-03-17 3:42 ` [PATCH v6 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs Liu Ying
2021-03-30 9:47 ` Robert Foss
2021-03-23 0:19 ` [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs Marcel Ziswiler
2021-03-23 9:07 ` Liu Ying
2021-03-23 1:03 ` Marcel Ziswiler
2021-03-23 9:09 ` Liu Ying
2021-03-29 0:49 ` Marcel Ziswiler
2021-03-29 8:05 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8905aad5ba0a37d1c889cfe612b785817d0f1193.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).