linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tracing/probe: fix memleak in fetch_op_data operations
Date: Mon, 15 Jun 2020 17:10:46 +0200	[thread overview]
Message-ID: <89f42852-80ef-1634-68fe-b7f686f8ce59@web.de> (raw)

…
> Post parse_probe_arg(), the FETCH_OP_DATA operation type is overwritten
> to FETCH_OP_ST_STRING, as a result memory is never freed …

How do you think about to use the term “memory leak” in the patch subject?

Will the tag “Fixes” become helpful for the commit message?

Regards,
Markus

             reply	other threads:[~2020-06-15 15:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 15:10 Markus Elfring [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-15 14:30 [PATCH] tracing/probe: fix memleak in fetch_op_data operations Vamshi K Sthambamkadi
2020-06-15 21:13 ` Steven Rostedt
2020-06-16  8:46   ` Masami Hiramatsu
2020-06-16 14:19     ` Oleg Nesterov
2020-06-16 16:21       ` Srikar Dronamraju
2020-06-16  8:41 ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89f42852-80ef-1634-68fe-b7f686f8ce59@web.de \
    --to=markus.elfring@web.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=vamshi.k.sthambamkadi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).