From: Sibi Sankar <sibis@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: robh+dt@kernel.org, andy.gross@linaro.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
rjw@rjwysocki.net, nm@ti.com, sboyd@kernel.org,
georgi.djakov@linaro.org, bjorn.andersson@linaro.org,
david.brown@linaro.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org, devicetree@vger.kernel.org,
rnayak@codeaurora.org, cw00.choi@samsung.com,
linux-pm@vger.kernel.org, evgreen@chromium.org,
daidavid1@codeaurora.org, dianders@chromium.org
Subject: Re: [PATCH RFC 7/9] cpufreq: qcom: Add support to update cpu node's OPP tables
Date: Wed, 10 Apr 2019 16:46:20 +0530 [thread overview]
Message-ID: <8aeedc48150da49b7ab2ce27dd45a455@codeaurora.org> (raw)
In-Reply-To: <20190410103316.sxev2f54klemq2p6@vireshk-i7>
On 2019-04-10 16:03, Viresh Kumar wrote:
> On 28-03-19, 20:58, Sibi Sankar wrote:
>> Add support to parse and update OPP tables attached to the cpu nodes.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> drivers/cpufreq/qcom-cpufreq-hw.c | 29 +++++++++++++++++++++++++++--
>> 1 file changed, 27 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c
>> b/drivers/cpufreq/qcom-cpufreq-hw.c
>> index 4b0b50403901..5c268dd2346c 100644
>> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
>> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
>> @@ -73,6 +73,25 @@ static unsigned int
>> qcom_cpufreq_hw_fast_switch(struct cpufreq_policy *policy,
>> return policy->freq_table[index].frequency;
>> }
>>
>> +static int qcom_find_update_opp(struct device *cpu_dev, unsigned long
>> freq,
>> + unsigned long volt)
>> +{
>> + int ret;
>> + struct dev_pm_opp *opp;
>> +
>> + opp = dev_pm_opp_find_freq_exact(cpu_dev, freq, true);
>> + if (IS_ERR(opp)) {
>> + ret = dev_pm_opp_add(cpu_dev, freq, volt);
>
> With my comment on the other patch, you can just call
> dev_pm_opp_update_voltage() and if that fails then call
> dev_pm_opp_add().
yeah that should simplify things.
Also through the above approach I cannot
really disable opps that the OSM does not
support. I can only try enabling opp's that
OSM supports. But that would require all
opp's nodes to start with "disabled" but
that is not allowed I guess.
>
>> + } else {
>> + dev_pm_opp_disable(cpu_dev, freq);
>> + ret = dev_pm_opp_update_voltage(cpu_dev, freq, volt);
>> + dev_pm_opp_enable(cpu_dev, freq);
>
> Perhaps no one else should be using the CPU OPP table at this point of
> time and
> so we can get away with disable and enable stuff ? Just add a comment
> on why
> that works.
we can get away without enable/disable here
>
>> + dev_pm_opp_put(opp);
>> + }
>> +
>> + return ret;
>> +}
>> +
>> static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev,
>> struct cpufreq_policy *policy,
>> void __iomem *base)
>> @@ -81,11 +100,16 @@ static int qcom_cpufreq_hw_read_lut(struct device
>> *cpu_dev,
>> u32 volt;
>> unsigned int max_cores = cpumask_weight(policy->cpus);
>> struct cpufreq_frequency_table *table;
>> + int ret;
>>
>> table = kcalloc(LUT_MAX_ENTRIES + 1, sizeof(*table), GFP_KERNEL);
>> if (!table)
>> return -ENOMEM;
>>
>> + ret = dev_pm_opp_of_add_table(cpu_dev);
>> + if (ret)
>> + dev_dbg(cpu_dev, "Couldn't add OPP table\n");
>> +
>> for (i = 0; i < LUT_MAX_ENTRIES; i++) {
>> data = readl_relaxed(base + REG_FREQ_LUT +
>> i * LUT_ROW_SIZE);
>> @@ -104,7 +128,7 @@ static int qcom_cpufreq_hw_read_lut(struct device
>> *cpu_dev,
>>
>> if (freq != prev_freq && core_count == max_cores) {
>> table[i].frequency = freq;
>> - dev_pm_opp_add(cpu_dev, freq * 1000, volt);
>> + qcom_find_update_opp(cpu_dev, freq * 1000, volt);
>> dev_dbg(cpu_dev, "index=%d freq=%d, core_count %d\n", i,
>> freq, core_count);
>> } else {
>> @@ -125,7 +149,8 @@ static int qcom_cpufreq_hw_read_lut(struct device
>> *cpu_dev,
>> if (prev_cc != max_cores) {
>> prev->frequency = prev_freq;
>> prev->flags = CPUFREQ_BOOST_FREQ;
>> - dev_pm_opp_add(cpu_dev, prev_freq * 1000, volt);
>> + qcom_find_update_opp(cpu_dev, prev_freq * 1000,
>> + volt);
>> }
>>
>> break;
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-04-10 11:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 15:28 [PATCH RFC 0/9] Add CPU based scaling support to Passive governor Sibi Sankar
2019-03-28 15:28 ` [PATCH RFC 1/9] OPP: Add and export helpers to get avg/peak bw Sibi Sankar
2019-03-28 15:28 ` [PATCH RFC 2/9] OPP: Export a number of helpers to prevent code duplication Sibi Sankar
2019-07-08 3:28 ` Hsin-Yi Wang
2019-07-10 8:01 ` Sibi Sankar
2019-03-28 15:28 ` [PATCH RFC 3/9] PM / devfreq: Add cpu based scaling support to passive_governor Sibi Sankar
2019-04-12 7:39 ` Chanwoo Choi
2019-05-27 8:23 ` Sibi Sankar
2019-05-28 1:27 ` Chanwoo Choi
2019-03-28 15:28 ` [PATCH RFC 4/9] dt-bindings: devfreq: Add bindings for devfreq dev-icbw driver Sibi Sankar
2019-03-28 15:28 ` [PATCH RFC 5/9] PM / devfreq: Add devfreq driver for interconnect bandwidth voting Sibi Sankar
2019-03-28 15:28 ` [PATCH RFC 6/9] OPP: Add and export helper to update voltage Sibi Sankar
2019-04-10 10:24 ` Viresh Kumar
2019-04-10 11:08 ` Sibi Sankar
2019-03-28 15:28 ` [PATCH RFC 7/9] cpufreq: qcom: Add support to update cpu node's OPP tables Sibi Sankar
2019-04-10 10:33 ` Viresh Kumar
2019-04-10 11:16 ` Sibi Sankar [this message]
2019-04-10 11:25 ` Viresh Kumar
2019-03-28 15:28 ` [PATCH RFC 8/9] arm64: dts: qcom: sdm845: Add cpu " Sibi Sankar
2019-03-28 15:28 ` [PATCH RFC 9/9] arm64: dts: qcom: sdm845: Add nodes for icbw driver and opp tables Sibi Sankar
2019-04-11 7:02 ` [PATCH RFC 0/9] Add CPU based scaling support to Passive governor Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aeedc48150da49b7ab2ce27dd45a455@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=daidavid1@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).