From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Souptick Joarder <jrdr.linux@gmail.com>,
akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com,
jgross@suse.com, linux@armlinux.org.uk, robin.murphy@arm.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 9/9] xen/privcmd-buf.c: Convert to use vm_insert_range_buggy
Date: Mon, 14 Jan 2019 18:31:12 -0500 [thread overview]
Message-ID: <8b0e0809-8e66-079d-1186-90b3f2df7a38@oracle.com> (raw)
In-Reply-To: <20190111151326.GA2853@jordon-HP-15-Notebook-PC>
On 1/11/19 10:13 AM, Souptick Joarder wrote:
> Convert to use vm_insert_range_buggy() to map range of kernel
> memory to user vma.
>
> This driver has ignored vm_pgoff. We could later "fix" these drivers
> to behave according to the normal vm_pgoff offsetting simply by
> removing the _buggy suffix on the function name and if that causes
> regressions, it gives us an easy way to revert.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/xen/privcmd-buf.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/xen/privcmd-buf.c b/drivers/xen/privcmd-buf.c
> index de01a6d..a9d7e97 100644
> --- a/drivers/xen/privcmd-buf.c
> +++ b/drivers/xen/privcmd-buf.c
> @@ -166,12 +166,8 @@ static int privcmd_buf_mmap(struct file *file, struct vm_area_struct *vma)
> if (vma_priv->n_pages != count)
> ret = -ENOMEM;
> else
> - for (i = 0; i < vma_priv->n_pages; i++) {
> - ret = vm_insert_page(vma, vma->vm_start + i * PAGE_SIZE,
> - vma_priv->pages[i]);
> - if (ret)
> - break;
> - }
> + ret = vm_insert_range_buggy(vma, vma_priv->pages,
> + vma_priv->n_pages);
This can use the non-buggy version. But since the original code was
indeed buggy in this respect I can submit this as a separate patch later.
So
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> if (ret)
> privcmd_buf_vmapriv_free(vma_priv);
next prev parent reply other threads:[~2019-01-14 23:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 15:13 [PATCH 9/9] xen/privcmd-buf.c: Convert to use vm_insert_range_buggy Souptick Joarder
2019-01-14 23:31 ` Boris Ostrovsky [this message]
2019-01-15 5:41 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b0e0809-8e66-079d-1186-90b3f2df7a38@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jgross@suse.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mhocko@suse.com \
--cc=robin.murphy@arm.com \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).